Re: [PATCH] fs: don't block i_writecount during exec

[Aishwarya TCV <aishwarya.tcv@arm.com>]

On 31/05/2024 14:01, Christian Brauner wrote:
> Back in 2021 we already discussed removing deny_write_access() for
> 
> executables. Back then I was hesistant because I thought that this might
> 
> cause issues in userspace. But even back then I had started taking some
> 
> notes on what could potentially depend on this and I didn't come up with
> 
> a lot so I've changed my mind and I would like to try this.
> 
> 
> 

Hi Christian,

LTP test "execve04" is failing when run against
next-master(next-20240606) kernel with Arm64 on JUNO in our CI.

A bisect identified 244ebddd34a0ab7b1ef865811864136873f4b67c as the
first bad commit. Bisected it on the tag "next-20240604" at repo
"https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git".

This works fine on Linux version 6.10-rc2

Failure log
------------
tst_test.c:1690: TINFO: LTP version: 20230929
tst_test.c:1574: TINFO: Timeout per run is 0h 01m 30s
execve_child.c:27: TFAIL: execve_child shouldn't be executed
tst_test.c:1622: TINFO: Killed the leftover descendant processes

Summary:
passed   0
failed   1
broken   0
skipped  0
warnings 0

Bisect log:
----------
git bisect start
# good: [c3f38fa61af77b49866b006939479069cd451173] Linux 6.10-rc2
git bisect good c3f38fa61af77b49866b006939479069cd451173
# bad: [d97496ca23a2d4ee80b7302849404859d9058bcd] Add linux-next
specific files for 20240604
git bisect bad d97496ca23a2d4ee80b7302849404859d9058bcd
# bad: [f89ceec12d7134c9be89f880655b72e36dd3c681] Merge branch
'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git
git bisect bad f89ceec12d7134c9be89f880655b72e36dd3c681
# good: [a933c8b54a9ea9bb6b10d168351638933c40b487] Merge branch
'for-next' of
git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
git bisect good a933c8b54a9ea9bb6b10d168351638933c40b487
# bad: [2d893301453cefb11116f6095a791b8013bbc3e9] Merge branch
'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git
git bisect bad 2d893301453cefb11116f6095a791b8013bbc3e9
# good: [a6a2e13e3bc64365c70b52d42b5d3a674152d5cd] Merge branch
'nfsd-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux
git bisect good a6a2e13e3bc64365c70b52d42b5d3a674152d5cd
# bad: [e4c1aa3f74bcc90cff6cf8ea575e222066f5be7b] Merge branch 'fs-next'
of linux-next
git bisect bad e4c1aa3f74bcc90cff6cf8ea575e222066f5be7b
# good: [37007c875042e5f5fc65087ea7d67ca388412875] Merge branch
'renesas-clk' of
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
git bisect good 37007c875042e5f5fc65087ea7d67ca388412875
# bad: [4247aca2219daab5ea6aeebc3d27d32ad56d2472] Merge branch
'vfs.module.description' into vfs.all
git bisect bad 4247aca2219daab5ea6aeebc3d27d32ad56d2472
# bad: [68efe7d9f3055ee986c51178e76061bdad782ff9] Merge branch
'vfs.xattr' into vfs.all
git bisect bad 68efe7d9f3055ee986c51178e76061bdad782ff9
# good: [1f9ccdf69c9ffb9a9084cc6e1a47c5030cebed26] readdir: Add missing
quote in macro comment
git bisect good 1f9ccdf69c9ffb9a9084cc6e1a47c5030cebed26
# bad: [03950a7a6f1a511a372bc46cd4fddd2df7e37a62] Merge branch
'vfs.misc' into vfs.all
git bisect bad 03950a7a6f1a511a372bc46cd4fddd2df7e37a62
# bad: [f113ef08b6bde5f4c74eb4d66f7ca52e09305bb0] tmpfs: don't interrupt
fallocate with EINTR
git bisect bad f113ef08b6bde5f4c74eb4d66f7ca52e09305bb0
# bad: [244ebddd34a0ab7b1ef865811864136873f4b67c] fs: don't block
i_writecount during exec
git bisect bad 244ebddd34a0ab7b1ef865811864136873f4b67c
# first bad commit: [244ebddd34a0ab7b1ef865811864136873f4b67c] fs: don't
block i_writecount during exec

Thanks,
Aishwarya