From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: linux-fsdevel@vger.kernel.org, Alexander Viro , Andy Whitcroft , Joe Perches From: SF Markus Elfring Subject: [PATCH] binfmt_flat: Delete two error messages for a failed memory allocation in decompress_exec() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: Date: Mon, 21 Aug 2017 08:54:05 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: From: Markus Elfring Date: Mon, 21 Aug 2017 08:43:50 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/binfmt_flat.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 604a176df0c2..ce6537c50ec1 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -192,13 +192,11 @@ static int decompress_exec( memset(&strm, 0, sizeof(strm)); strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL); - if (strm.workspace == NULL) { - pr_debug("no memory for decompress workspace\n"); + if (!strm.workspace) return -ENOMEM; - } + buf = kmalloc(LBUFSIZE, GFP_KERNEL); - if (buf == NULL) { - pr_debug("no memory for read buffer\n"); + if (!buf) { retval = -ENOMEM; goto out_free; } -- 2.14.0