From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Joanne Koong <joannelkoong@gmail.com>,
miklos@szeredi.hu, linux-fsdevel@vger.kernel.org
Cc: josef@toxicpanda.com, bernd.schubert@fastmail.fm, kernel-team@meta.com
Subject: Re: [PATCH 1/2] fuse: drop unused fuse_mount arg in fuse_writepage_finish
Date: Tue, 20 Aug 2024 09:53:05 +0800 [thread overview]
Message-ID: <f93cde51-d2f9-40c9-9ebb-fea1fbbf56d8@linux.alibaba.com> (raw)
In-Reply-To: <20240819182417.504672-1-joannelkoong@gmail.com>
On 8/20/24 2:24 AM, Joanne Koong wrote:
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
> ---
> fs/fuse/file.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index f39456c65ed7..63fd5fc6872e 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1769,8 +1769,7 @@ static void fuse_writepage_free(struct fuse_writepage_args *wpa)
> kfree(wpa);
> }
>
> -static void fuse_writepage_finish(struct fuse_mount *fm,
> - struct fuse_writepage_args *wpa)
> +static void fuse_writepage_finish(struct fuse_writepage_args *wpa)
> {
> struct fuse_args_pages *ap = &wpa->ia.ap;
> struct inode *inode = wpa->inode;
> @@ -1829,7 +1828,7 @@ __acquires(fi->lock)
> out_free:
> fi->writectr--;
> rb_erase(&wpa->writepages_entry, &fi->writepages);
> - fuse_writepage_finish(fm, wpa);
> + fuse_writepage_finish(wpa);
> spin_unlock(&fi->lock);
>
> /* After fuse_writepage_finish() aux request list is private */
> @@ -1959,7 +1958,7 @@ static void fuse_writepage_end(struct fuse_mount *fm, struct fuse_args *args,
> fuse_send_writepage(fm, next, inarg->offset + inarg->size);
> }
> fi->writectr--;
> - fuse_writepage_finish(fm, wpa);
> + fuse_writepage_finish(wpa);
> spin_unlock(&fi->lock);
> fuse_writepage_free(wpa);
> }
I'm afraid an empty commit message will trigger a warning when running
checkpatch. Otherwise LGTM.
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
--
Thanks,
Jingbo
next prev parent reply other threads:[~2024-08-20 1:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 18:24 [PATCH 1/2] fuse: drop unused fuse_mount arg in fuse_writepage_finish Joanne Koong
2024-08-19 18:24 ` [PATCH 2/2] fuse: update stats for pages in dropped aux writeback list Joanne Koong
2024-08-20 2:10 ` Jingbo Xu
2024-08-20 18:21 ` Joanne Koong
2024-08-21 15:56 ` Miklos Szeredi
2024-08-21 18:26 ` Bernd Schubert
2024-08-21 20:22 ` Joanne Koong
2024-08-22 10:54 ` Miklos Szeredi
2024-08-20 1:53 ` Jingbo Xu [this message]
2024-08-20 18:19 ` [PATCH 1/2] fuse: drop unused fuse_mount arg in fuse_writepage_finish Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f93cde51-d2f9-40c9-9ebb-fea1fbbf56d8@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=bernd.schubert@fastmail.fm \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).