From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E42DC77B7C for ; Tue, 25 Apr 2023 19:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234826AbjDYTMi (ORCPT ); Tue, 25 Apr 2023 15:12:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234802AbjDYTMg (ORCPT ); Tue, 25 Apr 2023 15:12:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE2D416F00; Tue, 25 Apr 2023 12:12:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D41463107; Tue, 25 Apr 2023 19:12:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51489C433EF; Tue, 25 Apr 2023 19:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682449953; bh=lMDAKv+dWFO6VkWUCnMr163Sk2UkfZaflcg85AFNg4o=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=hNysl+t5lkcBFn5CSWQ8toXWyK/+6AVSyIsFdzKmdx2nrRruksUKDv2q+kkco8ldw AatdU65HJvfsAWGaXB3bDdvB8Iyl/lNyjI3HnssP1fPjRZT4BL7xQRpNy+OFjPxyWp R3KEfAr8Pokc522ah0tFu5zUA6wFTCaDiJhgU7wP4eJkStWO7sA5DdiJUAyav5OsqP 5ItJNMp+T+9EZczVDYT+HEAxszUHJgYR9XlJ+m6d7Rl6L8PnRlakPeMx8ArQahyHTt rGKx6HvWdwqt86iZ7RQpBFrO5y3wRJgoq6qmLouQnQtwBQWcxEbbW7iBFlKP4rN1yX z9gGYrOyUWxXA== Message-ID: Subject: Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode i_m/ctime From: Jeff Layton To: Matthew Wilcox Cc: NeilBrown , Alexander Viro , Christian Brauner , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Dave Chinner , Chuck Lever , Jan Kara , Amir Goldstein , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Date: Tue, 25 Apr 2023 15:12:30 -0400 In-Reply-To: References: <20230424151104.175456-1-jlayton@kernel.org> <20230424151104.175456-2-jlayton@kernel.org> <168237287734.24821.11016713590413362200@noble.neil.brown.name> <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org> <168237601955.24821.11999779095797667429@noble.neil.brown.name> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 (3.48.0-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, 2023-04-25 at 18:56 +0100, Matthew Wilcox wrote: > On Tue, Apr 25, 2023 at 01:45:19PM -0400, Jeff Layton wrote: > > Erm...it may be an unpopular opinion, but I find that more confusing > > than just ensuring that the s_time_gran > 1. I keep wondering if we > > might want to carve out other low-order bits too for some later purpose= , > > at which point trying to check this using flags wouldn't work right. I > > think I might just stick with what I have here, at least for now. >=20 > But what if I set s_time_gran to 3 or 5? You'd really want a warning > about that. Ugh, I hadn't considered that. I don't see anyone that sets an odd s_time_gran that isn't 1, but OK, good point. I'll change it. --=20 Jeff Layton