From: Jeff Layton <jlayton@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Filesystems Development <linux-fsdevel@vger.kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Mateusz Guzik <mjguzik@gmail.com>, NeilBrown <neil@brown.name>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH 1/2] fs: Describe @isnew parameter in ilookup5_nowait()
Date: Fri, 19 Dec 2025 09:52:11 -0500 [thread overview]
Message-ID: <fa459e5fd28e81167397e768df0661cf78cfa636.camel@kernel.org> (raw)
In-Reply-To: <20251219024620.22880-2-bagasdotme@gmail.com>
On Fri, 2025-12-19 at 09:46 +0700, Bagas Sanjaya wrote:
> Sphinx reports kernel-doc warning:
>
> WARNING: ./fs/inode.c:1607 function parameter 'isnew' not described in 'ilookup5_nowait'
>
> Describe the parameter.
>
> Fixes: a27628f4363435 ("fs: rework I_NEW handling to operate without fences")
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> fs/inode.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 521383223d8a45..379f4c19845c95 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -1593,6 +1593,9 @@ EXPORT_SYMBOL(igrab);
> * @hashval: hash value (usually inode number) to search for
> * @test: callback used for comparisons between inodes
> * @data: opaque data pointer to pass to @test
> + * @isnew: return argument telling whether I_NEW was set when
> + * the inode was found in hash (the caller needs to
> + * wait for I_NEW to clear)
> *
> * Search for the inode specified by @hashval and @data in the inode cache.
> * If the inode is in the cache, the inode is returned with an incremented
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-12-19 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 2:46 [PATCH 0/2] vfs kernel-doc fixes for 6.19 Bagas Sanjaya
2025-12-19 2:46 ` [PATCH 1/2] fs: Describe @isnew parameter in ilookup5_nowait() Bagas Sanjaya
2025-12-19 13:50 ` Jan Kara
2025-12-19 14:52 ` Jeff Layton [this message]
2025-12-19 2:46 ` [PATCH 2/2] VFS: fix __start_dirop() kernel-doc warnings Bagas Sanjaya
2025-12-19 13:51 ` Jan Kara
2025-12-19 14:52 ` Jeff Layton
2025-12-27 4:45 ` NeilBrown
2025-12-24 12:33 ` [PATCH 0/2] vfs kernel-doc fixes for 6.19 Christian Brauner
2026-01-06 22:51 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa459e5fd28e81167397e768df0661cf78cfa636.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=amir73il@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=neil@brown.name \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox