* [PATCH 1/2] hfsplus: make splice write available again
@ 2025-05-29 14:00 Yangtao Li
2025-05-29 14:00 ` [PATCH 2/2] hfs: " Yangtao Li
2025-05-29 18:27 ` [PATCH 1/2] hfsplus: " Viacheslav Dubeyko
0 siblings, 2 replies; 6+ messages in thread
From: Yangtao Li @ 2025-05-29 14:00 UTC (permalink / raw)
To: slava, glaubitz, Yangtao Li, Kees Cook, Al Viro
Cc: linux-fsdevel, linux-kernel
Since 5.10, splice() or sendfile() return EINVAL. This was
caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
without explicit ops").
This patch initializes the splice_write field in file_operations, like
most file systems do, to restore the functionality.
Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
fs/hfsplus/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
index f331e9574217..c85b5802ec0f 100644
--- a/fs/hfsplus/inode.c
+++ b/fs/hfsplus/inode.c
@@ -368,6 +368,7 @@ static const struct file_operations hfsplus_file_operations = {
.write_iter = generic_file_write_iter,
.mmap = generic_file_mmap,
.splice_read = filemap_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = hfsplus_file_fsync,
.open = hfsplus_file_open,
.release = hfsplus_file_release,
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] hfs: make splice write available again
2025-05-29 14:00 [PATCH 1/2] hfsplus: make splice write available again Yangtao Li
@ 2025-05-29 14:00 ` Yangtao Li
2025-05-29 18:28 ` Viacheslav Dubeyko
2025-05-29 18:27 ` [PATCH 1/2] hfsplus: " Viacheslav Dubeyko
1 sibling, 1 reply; 6+ messages in thread
From: Yangtao Li @ 2025-05-29 14:00 UTC (permalink / raw)
To: slava, glaubitz, Yangtao Li, Kees Cook, Al Viro
Cc: linux-fsdevel, linux-kernel
Since 5.10, splice() or sendfile() return EINVAL. This was
caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
without explicit ops").
This patch initializes the splice_write field in file_operations, like
most file systems do, to restore the functionality.
Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
fs/hfs/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c
index a81ce7a740b9..451115360f73 100644
--- a/fs/hfs/inode.c
+++ b/fs/hfs/inode.c
@@ -692,6 +692,7 @@ static const struct file_operations hfs_file_operations = {
.write_iter = generic_file_write_iter,
.mmap = generic_file_mmap,
.splice_read = filemap_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = hfs_file_fsync,
.open = hfs_file_open,
.release = hfs_file_release,
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] hfs: make splice write available again
2025-05-29 14:00 ` [PATCH 2/2] hfs: " Yangtao Li
@ 2025-05-29 18:28 ` Viacheslav Dubeyko
2025-06-06 23:04 ` Viacheslav Dubeyko
0 siblings, 1 reply; 6+ messages in thread
From: Viacheslav Dubeyko @ 2025-05-29 18:28 UTC (permalink / raw)
To: frank.li@vivo.com, glaubitz@physik.fu-berlin.de,
slava@dubeyko.com, viro@zeniv.linux.org.uk, kees@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote:
> Since 5.10, splice() or sendfile() return EINVAL. This was
> caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
> without explicit ops").
>
> This patch initializes the splice_write field in file_operations, like
> most file systems do, to restore the functionality.
>
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/hfs/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c
> index a81ce7a740b9..451115360f73 100644
> --- a/fs/hfs/inode.c
> +++ b/fs/hfs/inode.c
> @@ -692,6 +692,7 @@ static const struct file_operations hfs_file_operations = {
> .write_iter = generic_file_write_iter,
> .mmap = generic_file_mmap,
> .splice_read = filemap_splice_read,
> + .splice_write = iter_file_splice_write,
> .fsync = hfs_file_fsync,
> .open = hfs_file_open,
> .release = hfs_file_release,
Makes sense.
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Thanks,
Slava.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] hfs: make splice write available again
2025-05-29 18:28 ` Viacheslav Dubeyko
@ 2025-06-06 23:04 ` Viacheslav Dubeyko
0 siblings, 0 replies; 6+ messages in thread
From: Viacheslav Dubeyko @ 2025-06-06 23:04 UTC (permalink / raw)
To: Christian Brauner
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Viacheslav Dubeyko, frank.li@vivo.com,
glaubitz@physik.fu-berlin.de, viro@zeniv.linux.org.uk,
kees@kernel.org
Hi Christian,
Could you please pick up the patch?
Thanks,
Slava.
On Thu, 2025-05-29 at 18:28 +0000, Viacheslav Dubeyko wrote:
> On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote:
> > Since 5.10, splice() or sendfile() return EINVAL. This was
> > caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
> > without explicit ops").
> >
> > This patch initializes the splice_write field in file_operations,
> > like
> > most file systems do, to restore the functionality.
> >
> > Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without
> > explicit ops")
> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
> > ---
> > fs/hfs/inode.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c
> > index a81ce7a740b9..451115360f73 100644
> > --- a/fs/hfs/inode.c
> > +++ b/fs/hfs/inode.c
> > @@ -692,6 +692,7 @@ static const struct file_operations
> > hfs_file_operations = {
> > .write_iter = generic_file_write_iter,
> > .mmap = generic_file_mmap,
> > .splice_read = filemap_splice_read,
> > + .splice_write = iter_file_splice_write,
> > .fsync = hfs_file_fsync,
> > .open = hfs_file_open,
> > .release = hfs_file_release,
>
> Makes sense.
>
> Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
>
> Thanks,
> Slava.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] hfsplus: make splice write available again
2025-05-29 14:00 [PATCH 1/2] hfsplus: make splice write available again Yangtao Li
2025-05-29 14:00 ` [PATCH 2/2] hfs: " Yangtao Li
@ 2025-05-29 18:27 ` Viacheslav Dubeyko
2025-06-06 23:04 ` Viacheslav Dubeyko
1 sibling, 1 reply; 6+ messages in thread
From: Viacheslav Dubeyko @ 2025-05-29 18:27 UTC (permalink / raw)
To: frank.li@vivo.com, glaubitz@physik.fu-berlin.de,
slava@dubeyko.com, viro@zeniv.linux.org.uk, kees@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote:
> Since 5.10, splice() or sendfile() return EINVAL. This was
> caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
> without explicit ops").
>
> This patch initializes the splice_write field in file_operations, like
> most file systems do, to restore the functionality.
>
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/hfsplus/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index f331e9574217..c85b5802ec0f 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -368,6 +368,7 @@ static const struct file_operations hfsplus_file_operations = {
> .write_iter = generic_file_write_iter,
> .mmap = generic_file_mmap,
> .splice_read = filemap_splice_read,
> + .splice_write = iter_file_splice_write,
> .fsync = hfsplus_file_fsync,
> .open = hfsplus_file_open,
> .release = hfsplus_file_release,
Makes sense.
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Thanks,
Slava.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] hfsplus: make splice write available again
2025-05-29 18:27 ` [PATCH 1/2] hfsplus: " Viacheslav Dubeyko
@ 2025-06-06 23:04 ` Viacheslav Dubeyko
0 siblings, 0 replies; 6+ messages in thread
From: Viacheslav Dubeyko @ 2025-06-06 23:04 UTC (permalink / raw)
To: Christian Brauner
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Viacheslav Dubeyko, frank.li@vivo.com,
glaubitz@physik.fu-berlin.de, viro@zeniv.linux.org.uk,
kees@kernel.org
Hi Christian,
Could you please pick up the patch?
Thanks,
Slava.
On Thu, 2025-05-29 at 18:27 +0000, Viacheslav Dubeyko wrote:
> On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote:
> > Since 5.10, splice() or sendfile() return EINVAL. This was
> > caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
> > without explicit ops").
> >
> > This patch initializes the splice_write field in file_operations,
> > like
> > most file systems do, to restore the functionality.
> >
> > Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without
> > explicit ops")
> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
> > ---
> > fs/hfsplus/inode.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> > index f331e9574217..c85b5802ec0f 100644
> > --- a/fs/hfsplus/inode.c
> > +++ b/fs/hfsplus/inode.c
> > @@ -368,6 +368,7 @@ static const struct file_operations
> > hfsplus_file_operations = {
> > .write_iter = generic_file_write_iter,
> > .mmap = generic_file_mmap,
> > .splice_read = filemap_splice_read,
> > + .splice_write = iter_file_splice_write,
> > .fsync = hfsplus_file_fsync,
> > .open = hfsplus_file_open,
> > .release = hfsplus_file_release,
>
> Makes sense.
>
> Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
>
> Thanks,
> Slava.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-06 23:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-29 14:00 [PATCH 1/2] hfsplus: make splice write available again Yangtao Li
2025-05-29 14:00 ` [PATCH 2/2] hfs: " Yangtao Li
2025-05-29 18:28 ` Viacheslav Dubeyko
2025-06-06 23:04 ` Viacheslav Dubeyko
2025-05-29 18:27 ` [PATCH 1/2] hfsplus: " Viacheslav Dubeyko
2025-06-06 23:04 ` Viacheslav Dubeyko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).