From: Paul Wise <pabs3@bonedaddy.net>
To: Matthew Ruffell <matthew.ruffell@canonical.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jakub Wilk <jwilk@jwilk.net>
Subject: Re: [PATCH 0/1] coredump: Fix null pointer dereference when kernel.core_pattern is "|"
Date: Sat, 14 Mar 2020 08:28:10 +0800 [thread overview]
Message-ID: <fa636317af3a38badff322ca11e437701154b1be.camel@bonedaddy.net> (raw)
In-Reply-To: <87a47997-3cde-bc86-423b-6154849183e9@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Tue, 2020-03-10 at 11:34 +1300, Matthew Ruffell wrote:
> Can I please get some feedback on this patch? Would be good to clear
> up the null pointer dereference.
I had a thought about it, instead of using strlen, what about checking
that the first item in the array is NUL or not? In the normal case this
should be faster than strlen.
--
bye,
pabs
https://bonedaddy.net/pabs3/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-14 0:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 5:10 [PATCH 0/1] coredump: Fix null pointer dereference when kernel.core_pattern is "|" Matthew Ruffell
2020-02-20 5:10 ` [PATCH 1/1] " Matthew Ruffell
2020-02-22 14:17 ` [PATCH 0/1] " Paul Wise
2020-03-09 22:34 ` Matthew Ruffell
2020-03-14 0:28 ` Paul Wise [this message]
2020-03-14 21:35 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa636317af3a38badff322ca11e437701154b1be.camel@bonedaddy.net \
--to=pabs3@bonedaddy.net \
--cc=akpm@linux-foundation.org \
--cc=jwilk@jwilk.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.ruffell@canonical.com \
--cc=nhorman@tuxdriver.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox