From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90164229B18 for ; Mon, 4 May 2026 03:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777867027; cv=none; b=n4eHba/PqhTXreYId5AZ9QCa1btst/TjOgYoJrMkk2lqNx2jT6r6wwseWEAIV7p8Wou01ScFmYU3pam0AgAcC+lPmtqUK4/nYB9isl+mZs7QhHhSTaHCKxHkovezKfyV2kzZQ2zEwMrDU5B/wcdDfZcHq3U2MlsXXQSToogLUmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777867027; c=relaxed/simple; bh=v/hn59alj5J7N2H22CfQHHEbWjJ2B0vjPYXnMKwqp/M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KVnJPqqzXKgF2zSgzmSDK//NF3RNNwPvTqouvmw+Sw4Hrz8G/ajwIZ5iT+833+VUgmF0D+0z/SapH+8PHBz0mh5A8x6zbzQJAto8PKrPpd6OyQQaMGfGz7OhPvr+yVt5UCNbRBIxisU9ifgCUxOE9iYtuXZGMUJ9Yanuqqzbw4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UBSiXzWW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rueF3pkF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UBSiXzWW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rueF3pkF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777867023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qmtvy+Ja1TH//9Y34ehxEV0VvVTj9S6URXD/jFo8hZY=; b=UBSiXzWWm+BNmsCDCzUOhI0oWtyyxy2Xx9cSEgr52JUXOzVvnmThE6KffgcUKUkWpiiDw9 Ep2lHQjVoSkfhyVGj/CXXX4uTPx/YvIZRJRU6ANwmEkQSqmUKu/d2J90kyM0cUiHO0FguX 1nDOiK5hQvwkTzSJ/vl7MENTDXIWgNU= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-jpEGVc_VMrecNLIq6E8Svg-1; Sun, 03 May 2026 23:57:02 -0400 X-MC-Unique: jpEGVc_VMrecNLIq6E8Svg-1 X-Mimecast-MFC-AGG-ID: jpEGVc_VMrecNLIq6E8Svg_1777867022 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-7af89eabe49so72561087b3.0 for ; Sun, 03 May 2026 20:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777867022; x=1778471822; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qmtvy+Ja1TH//9Y34ehxEV0VvVTj9S6URXD/jFo8hZY=; b=rueF3pkFqbS3nsu8xuz80AomRvD5fgM9mKSRzOvaXyTkou78HOMtP5EWb17uOWBk4O zdOFqut2TFH5sm/lIet67bkxog8hsTbXDWf2In4DU0nZCvcRceT5JrW868GtzyR3U3zT vtloQshGOM1ZBs/DkG+VyJjEq7zOERszvzU1UJPhvRmUw3xJMaJRItxb8el2Psjy59hn NDnAEv9FJL8s6pAT9QQmIezj1V5Si4GQQhklUIKrzZlh1NYlW4d/+ZzatHhA1mNN9xC4 OfbjTLI+c0mVZkt9WWgNT1puEnL1EJTYHskEX/8qg6TfblQrrfY4Iros9zj1p6q/vcyr E/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777867022; x=1778471822; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qmtvy+Ja1TH//9Y34ehxEV0VvVTj9S6URXD/jFo8hZY=; b=LACEomIw6M5kTir+1a/So08HVPDqTrzpRqnXCSN0HtUh+YWHDuB2WTS+CrM1kgX5ee zgflLau1ZIyUXdSGVOiSN7pwEBFhFd2AWU2D6wNgEDCoMx4Wg/BErpRhNcn1AePrt3xw 3wdFnc/hDh3kEEHNgVFnuav8Nb/OGtDuRemNnsiPsKNwB4dWz4BSDDKbJf4qlhfnuvr9 /nNRgzM3xuvjZS5ALSqfA9WEdejy0hl/UEgvD2mmdENR2kbQX8Xo5GMCINI3Y2b30z4Z rv2Tjv3kwPvJ7YV9yO7LQUU3k9acfeMFyflhi5T1ndTWdDw5J2SZnq7l/w+xCJpT4vjU 9w1Q== X-Forwarded-Encrypted: i=1; AFNElJ+sqMAEdFA6VTBtkNPLcCYqjg+WPXnoU8DiIEWsVzkyeXCVmv0sNac31OHzYbw97fyOTNYKX7964Vh9p+Zn@vger.kernel.org X-Gm-Message-State: AOJu0Yx1nIIv6ANAnBVM4oXTBmni9FlFTbrmyti0s0orbziH7AiDt/nS ca7Jirn6+YKtRVvv/ca9wslpAsXB4C9RRtNXWQ13qGcGz+oGrhqMHjkUjTl72Tpc9Y19MMPnaZq XiULBc2aW+c/pEArPA9rIN5qkqSoWaElRy0+7BdHxGFJT5aoWz0QKL+C/J1CrNnOdWZs= X-Gm-Gg: AeBDiesOwEzBMB/bKATkKEgmfZDQav5R79Quj6BNNEt14oZJJVabownhkVTOYN5PjA6 oMc56Hiu+y9nMf4YURxnk8oKS14dd0X2nwFZ6h9DXSQfmro1brA6Cma46LzI2F9dU3nxpma1za+ z9mvBqoZHcLraUE25MILG4Qwe+4B9Zy3cp0AFIFes9sjZY6lB32lub4pYsPjzX/7MUqOvq9ZqyD S9eUbWDEZ3WhxCzI9epmY/f9mFG/rreGii4fU9k/jtTcC7nLwVsnXBxFQbK7VWKoTH6lBbMDY86 PyzqPi4XLJRDEbyQahyz5uipLOhQu5MdUGzL5Qe4MnueOw2/BKGa4Fz5bibdNU2jFXrI2WR2N2H R0y5q1+CpJMN6iXdMhO4g7OptV98PfAmYhRBLLbVko4scJkSg/GVxqrLLoQf7g+inF+c= X-Received: by 2002:a05:690c:e094:b0:7b8:c19c:ee9a with SMTP id 00721157ae682-7bd770db6a4mr85526647b3.32.1777867021826; Sun, 03 May 2026 20:57:01 -0700 (PDT) X-Received: by 2002:a05:690c:e094:b0:7b8:c19c:ee9a with SMTP id 00721157ae682-7bd770db6a4mr85526497b3.32.1777867021452; Sun, 03 May 2026 20:57:01 -0700 (PDT) Received: from [192.168.178.105] (78-0-206-107.adsl.net.t-com.hr. [78.0.206.107]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd6683aa8asm44078807b3.26.2026.05.03.20.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 May 2026 20:57:01 -0700 (PDT) Message-ID: Date: Sun, 3 May 2026 21:57:33 -0600 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/14] mm/huge_memory: remove READ_ONLY_THP_FOR_FS from file_thp_enabled() To: Zi Yan , Andrew Morton , David Hildenbrand , "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20260429152924.727124-1-ziy@nvidia.com> <20260429152924.727124-4-ziy@nvidia.com> Content-Language: en-US From: Nico Pache In-Reply-To: <20260429152924.727124-4-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/29/26 9:29 AM, Zi Yan wrote: > Replace it with a check on the max folio order of the file's address space > mapping, making sure PMD folio is supported. Keep the inode open-for-write > check, since even if collapse_file() now makes sure all to-be-collapsed > folios are clean and the created PMD file THP can be handled by FSes > properly, the filemap_flush() could perform undesirable write back. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 2f3fcb4dd1ef8..3b324f03e9283 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -86,9 +86,6 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma) > { > struct inode *inode; > > - if (!IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) > - return false; > - > if (!vma->vm_file) > return false; > > @@ -97,6 +94,9 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma) > if (IS_ANON_FILE(inode)) > return false; > > + if (!mapping_pmd_folio_support(vma->vm_file->f_mapping)) Other than my question in the previous patch about >= PMD_ORDER vs == PMD_ORDER. LGTM Reviewed-by: Nico Pache > + return false; > + > return !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode); > } >