From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC0DC2BB48 for ; Tue, 15 Dec 2020 16:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13512224F4 for ; Tue, 15 Dec 2020 16:22:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730956AbgLOQWO (ORCPT ); Tue, 15 Dec 2020 11:22:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728235AbgLOQU6 (ORCPT ); Tue, 15 Dec 2020 11:20:58 -0500 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 288CDC0617B0 for ; Tue, 15 Dec 2020 08:20:10 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id q137so21028503iod.9 for ; Tue, 15 Dec 2020 08:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cepPKu2YWOPZxpSDeaZeJhoYzcrR4WvsyJobJwX+cEc=; b=jQfglxdlcpjwlCFYyRKad59C0OEt5BWrVVeVe1DKWwGLkeZnvvjbLlJ7HInYMsaqFz qtdpxVJVA1MTUBvDF80/01zIsS2bPvnUzS87uHhxvRdMT1vH3o5mnZ8KAQeKHZeK74LL IySCLeVfBPSHbBMQTlS+3IJDhgC9C1sKTQWNC6DkTuv3PamR9RYYrqSul/AuqzAuiG44 zLYTzcHKR2l9PajGAA7vZmCbqSttLw3+6ExgtzBL3OG5El/rIsi/5TBc1Z1Pb4n3p6CN nzGG8pdnoQ48GcrrrkFTCXPScfRELCKGaR/7DPx24KbvKwpL7qKxi82I24Ae/xMYz9Sq 5DvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cepPKu2YWOPZxpSDeaZeJhoYzcrR4WvsyJobJwX+cEc=; b=PWpv7gTf6c4yyEYhRJsLCL4s04Jo0NI+I3sP5fc1QebecwW+iQej9vliNx0qU1GQrr SK6ZH/UR3ptBTt7C1LPun3wASSULI7EkGrB+dIxWTjLUUyeQU9a/hUBLUXQhfj9AzayY KggID4+gJ3Rd641Yw8sNirJNpGfP3UDmndTCZNSIrOC0cjEEYAtpXmukvQVJvcAJq1vX 6t7hNBwpidWcN/2Nhlbj2A6r7eV1V0NXXzOtoRf4GaKQ3poE68sonLEmXRK4FMwc0EJ/ sCPiZzq+lZJIsaAoTU8CFNp/sLDgoKiJd5m4rNosDeXb5oAOWP57gw/DHkwbc+f+6OIT MOWw== X-Gm-Message-State: AOAM530WNEmi+NOEJ6EjMbyNEtcZ8RfyMB4/fC/Vs+ZVLfkByKxEEcGI MRYgHlrbYrpwqI/U8/tZ9XKeHmkMGmfKRg== X-Google-Smtp-Source: ABdhPJxrv7RdVYxK2HHPkxKa0iwCPR0qpoB0UlMbi1sTvAwnuTsoszvGvdwO9TJ1HOwagg8HsddCXw== X-Received: by 2002:a02:ce2f:: with SMTP id v15mr40055639jar.44.1608049209264; Tue, 15 Dec 2020 08:20:09 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id t14sm1523148iof.23.2020.12.15.08.20.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 08:20:08 -0800 (PST) Subject: Re: [PATCH 0/2] io_uring: add mkdirat support To: Dmitry Kadashev , viro@zeniv.linux.org.uk Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20201116044529.1028783-1-dkadashev@gmail.com> From: Jens Axboe Message-ID: Date: Tue, 15 Dec 2020 09:20:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 12/15/20 4:43 AM, Dmitry Kadashev wrote: > On Fri, Dec 4, 2020 at 5:57 PM Dmitry Kadashev wrote: >> >> On Mon, Nov 16, 2020 at 11:45:27AM +0700, Dmitry Kadashev wrote: >>> This adds mkdirat support to io_uring and is heavily based on recently >>> added renameat() / unlinkat() support. >>> >>> The first patch is preparation with no functional changes, makes >>> do_mkdirat accept struct filename pointer rather than the user string. >>> >>> The second one leverages that to implement mkdirat in io_uring. >>> >>> Based on for-5.11/io_uring. >>> >>> Dmitry Kadashev (2): >>> fs: make do_mkdirat() take struct filename >>> io_uring: add support for IORING_OP_MKDIRAT >>> >>> fs/internal.h | 1 + >>> fs/io_uring.c | 58 +++++++++++++++++++++++++++++++++++ >>> fs/namei.c | 20 ++++++++---- >>> include/uapi/linux/io_uring.h | 1 + >>> 4 files changed, 74 insertions(+), 6 deletions(-) >>> >>> -- >>> 2.28.0 >>> >> >> Hi Al Viro, >> >> Ping. Jens mentioned before that this looks fine by him, but you or >> someone from fsdevel should approve the namei.c part first. > > Another ping. > > Jens, you've mentioned the patch looks good to you, and with quite > similar changes (unlinkat, renameat) being sent for 5.11 is there > anything that I can do to help this to be accepted (not necessarily > for 5.11 at this point)? Since we're aiming for 5.12 at this point, let's just hold off a bit and see if Al gets time to ack/review the VFS side of things. There's no immediate rush. It's on my TODO list, so we'll get there eventually. -- Jens Axboe