From: Jane Chu <jane.chu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "david@fromorbit.com" <david@fromorbit.com>,
"djwong@kernel.org" <djwong@kernel.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
"dave.jiang@intel.com" <dave.jiang@intel.com>,
"agk@redhat.com" <agk@redhat.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"ira.weiny@intel.com" <ira.weiny@intel.com>,
"willy@infradead.org" <willy@infradead.org>,
"vgoyal@redhat.com" <vgoyal@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v6 3/6] mce: fix set_mce_nospec to always unmap the whole page
Date: Tue, 22 Mar 2022 22:45:01 +0000 [thread overview]
Message-ID: <fb1ca254-3e7d-0931-2bfa-8f7f27b7d4fd@oracle.com> (raw)
In-Reply-To: <YjmMWvDRUHE08T+a@infradead.org>
On 3/22/2022 1:44 AM, Christoph Hellwig wrote:
> On Sat, Mar 19, 2022 at 12:28:30AM -0600, Jane Chu wrote:
>> Mark poisoned page as not present, and to reverse the 'np' effect,
>> restate the _PAGE_PRESENT bit. Please refer to discussions here for
>> reason behind the decision.
>> https://lore.kernel.org/all/CAPcyv4hrXPb1tASBZUg-GgdVs0OOFKXMXLiHmktg_kFi7YBMyQ@mail.gmail.com/
>
> I think it would be good to summarize the conclusion here instead of
> just linking to it.
Sure, will do.
>
>> +static int _set_memory_present(unsigned long addr, int numpages)
>> +{
>> + return change_page_attr_set(&addr, numpages, __pgprot(_PAGE_PRESENT), 0);
>> +}
>
> What is the point of this trivial helper with a single caller?
>
Okay, will remove the helper.
thanks!
-jane
next prev parent reply other threads:[~2022-03-22 22:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 6:28 [PATCH v6 0/6] DAX poison recovery Jane Chu
2022-03-19 6:28 ` [PATCH v6 1/6] x86/mm: fix comment Jane Chu
2022-03-22 8:40 ` Christoph Hellwig
2022-03-19 6:28 ` [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions Jane Chu
2022-03-19 8:13 ` kernel test robot
2022-03-19 8:24 ` kernel test robot
2022-03-22 8:42 ` Christoph Hellwig
2022-03-22 22:19 ` Jane Chu
2022-03-22 22:41 ` Borislav Petkov
2022-03-22 23:48 ` Jane Chu
2022-03-19 6:28 ` [PATCH v6 3/6] mce: fix set_mce_nospec to always unmap the whole page Jane Chu
2022-03-22 8:44 ` Christoph Hellwig
2022-03-22 22:45 ` Jane Chu [this message]
2022-03-19 6:28 ` [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops Jane Chu
2022-03-19 8:24 ` kernel test robot
2022-03-19 8:44 ` kernel test robot
2022-03-22 9:01 ` Christoph Hellwig
2022-03-22 23:05 ` Jane Chu
2022-03-23 5:45 ` Christoph Hellwig
2022-03-23 18:43 ` Jane Chu
2022-03-24 6:37 ` Christoph Hellwig
2022-03-26 6:31 ` Jane Chu
2022-03-19 6:28 ` [PATCH v6 5/6] pmem: refactor pmem_clear_poison() Jane Chu
2022-03-22 8:53 ` Christoph Hellwig
2022-03-22 23:45 ` Jane Chu
2022-03-19 6:28 ` [PATCH v6 6/6] pmem: implement pmem_recovery_write() Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1ca254-3e7d-0931-2bfa-8f7f27b7d4fd@oracle.com \
--to=jane.chu@oracle.com \
--cc=agk@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=snitzer@redhat.com \
--cc=vgoyal@redhat.com \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).