From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D85524A for ; Sat, 10 Feb 2024 04:59:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707541186; cv=none; b=cbNSKMbvbeW0cVWSoC7bdiaCiaQJY6vQJG2s68uq7fvM+BjjywG0tVkz6uvi0HZ9N/P5ZnqmH5ecUy299yP1Rabta2voWqgb9KQd8E0DYjpMszZwoullN/8ubzXJcYGFRI38Z8eBhOJxytxSRVo2a9mZF/u5uNs9pbKdux8yLME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707541186; c=relaxed/simple; bh=1hMSzKlU/8kdzNK0ZhfKer6MS58iESJPzqeH9XaJRhk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=puNGy7eqvR8a+sHrb64rLIfwTwK7DNa0DBGsoqVfV6dQT2N/hoUmX10gjqt2HkEIh9smy61qjK/Ds3PsU6hcbn9l27jDvrnasPFpH+/LB+tmU7atN/4dxlRkD8/K3c2CqP1hKe0P1QNmqsKR3apeWECZ4p4mbtNZyhpbdQVm4X8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=iJ3OtuSV; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iJ3OtuSV" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=3Nljb9PCm+3BSksLB4/hye2aApASFSnrOrHjYRJX5Kk=; b=iJ3OtuSV5XS2/o4y71qAOLhhjW iAWpvuu4D2hHS53tl/JLJslI+Ub5O8dSN4eew0QtNuiR6wXpBo+17Dq8akHdlO2P6nqjiczbBPOJg gHpBKnmA47Gk+WJHq1QOQvAxhMO/Qh/Ut2v+e9ZP89n4I3qWbOC13OHQJRXjIoZqoyVFXIWqy7XHL Xuq+yRlhduOnZ+qF1Tp/Uk2sKGji98Uf4nGpJnuZB9guE56vP5SXCEwCmDVBNPdYia9Xw81qbpxtK UDoi7v378I+2VuFDl+cXHmXcRN8dLsrm6KbjeMh8JLPf8RNfZ1GOvJsZTBKZ3YN1eAMLCUfvfUUla agt6NNtA==; Received: from [50.53.50.0] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rYfSp-00000001DjS-3MFq; Sat, 10 Feb 2024 04:59:43 +0000 Message-ID: Date: Fri, 9 Feb 2024 20:59:41 -0800 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs/hfsplus: wrapper.c: fix kernel-doc warnings Content-Language: en-US To: Bart Van Assche , linux-fsdevel@vger.kernel.org Cc: Alexander Viro , Christian Brauner , Jens Axboe References: <20231206024317.31020-1-rdunlap@infradead.org> <8e6759b1-15da-40b7-85a5-7c6ae91d51e5@acm.org> From: Randy Dunlap In-Reply-To: <8e6759b1-15da-40b7-85a5-7c6ae91d51e5@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/9/24 13:57, Bart Van Assche wrote: > On 12/5/23 18:43, Randy Dunlap wrote: >> - * @op: direction of I/O >> - * @op_flags: request op flags >> + * @opf: request op flags > > (just noticed this patch) > > The new comment is worse than the original comments. This would be a > better explanation of the 'opf' argument: > > + * @opf: I/O operation type and flags Agreed. I'll send an update. thanks. -- #Randy