From: Randy Dunlap <rdunlap@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Aring <alex.aring@gmail.com>,
Josef Bacik <josef@toxicpanda.com>,
Aleksa Sarai <cyphar@cyphar.com>, Jan Kara <jack@suse.cz>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] uapi/fcntl: conditionally define AT_RENAME* macros
Date: Mon, 25 Aug 2025 12:29:54 -0700 [thread overview]
Message-ID: <fc0b3998-df4a-49d0-88a6-e2c1c5c6650c@infradead.org> (raw)
In-Reply-To: <aKyvO2bvPCZEzuBd@casper.infradead.org>
On 8/25/25 11:45 AM, Matthew Wilcox wrote:
> On Mon, Aug 25, 2025 at 10:52:31AM -0700, Randy Dunlap wrote:
>> $ grep -r AT_RENAME_NOREPLACE /usr/include
>> /usr/include/stdio.h:# define AT_RENAME_NOREPLACE RENAME_NOREPLACE
>> /usr/include/linux/fcntl.h:#define AT_RENAME_NOREPLACE 0x0001
>>
>> I have libc 2.42-1.1 (openSUSE).
>
> I wonder if we can fix it by changing include/uapi/linux/fcntl.h
> from being an explicit 0x0001 to RENAME_NOREPLACE? There's probably
> a horrendous include problem between linux/fcntl.h and linux/fs.h
> though?
I'm working on something like that now (suggested by Amir),
but it might depend on whether stdio.h has been #included first.
--
~Randy
prev parent reply other threads:[~2025-08-25 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 22:10 [PATCH] uapi/fcntl: conditionally define AT_RENAME* macros Randy Dunlap
2025-08-24 23:21 ` Matthew Wilcox
2025-08-24 23:54 ` Randy Dunlap
2025-08-25 5:58 ` Amir Goldstein
2025-08-25 6:49 ` Randy Dunlap
2025-08-25 13:03 ` Matthew Wilcox
2025-08-25 17:52 ` Randy Dunlap
2025-08-25 18:45 ` Matthew Wilcox
2025-08-25 19:29 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc0b3998-df4a-49d0-88a6-e2c1c5c6650c@infradead.org \
--to=rdunlap@infradead.org \
--cc=alex.aring@gmail.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=cyphar@cyphar.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).