From: "J. Bruce Fields" <bfields@citi.umich.edu>
To: linux-fsdevel@vger.kernel.org
Cc: nfs@lists.sourceforge.net, Marc Eshel <eshel@almaden.ibm.com>
Subject: [PATCH 6/14] locks: add lock cancel command
Date: Sat, 3 Feb 2007 00:34:02 -0500 [thread overview]
Message-ID: <6816.47257083586$1170480891@news.gmane.org> (raw)
Message-ID: <fdf19cb6a33a08dd9220cdf2379d712d3c15e66f.1170479265.git.bfields@citi.umich.edu> (raw)
In-Reply-To: <11704808513070-git-send-email->
In-Reply-To: <ad8373acbb12f165b625f6065bc0ca86f3982b7f.1170479265.git.bfields@citi.umich.edu>
From: Marc Eshel <eshel@almaden.ibm.com> - unquoted
Lock managers need to be able to cancel pending lock requests. In the case
where the exported filesystem manages its own locks, it's not sufficient just
to call posix_unblock_lock(); we need to let the filesystem know what's
happening too.
We do this by adding a new fcntl lock command: FL_CANCELLK. Some day this
might also be made available to userspace applications that could benefit from
an asynchronous locking api.
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
---
fs/locks.c | 17 +++++++++++++++++
include/linux/fcntl.h | 4 ++++
include/linux/lockd/bind.h | 1 +
3 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 819dc28..8ee72b3 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2061,6 +2061,23 @@ posix_unblock_lock(struct file *filp, struct file_lock *waiter)
EXPORT_SYMBOL(posix_unblock_lock);
+/**
+ * vfs_cancel_lock - file byte range unblock lock
+ * @filp: The file to apply the unblock to
+ * @fl: The lock to be unblocked
+ *
+ * Used by lock managers to cancel blocked requests
+ */
+int vfs_cancel_lock(struct file *filp, struct file_lock *fl)
+{
+ if (filp->f_op && filp->f_op->lock)
+ return filp->f_op->lock(filp, F_CANCELLK, fl);
+ else
+ return posix_unblock_lock(filp, fl);
+}
+
+EXPORT_SYMBOL(vfs_cancel_lock);
+
static void lock_get_status(char* out, struct file_lock *fl, int id, char *pfx)
{
struct inode *inode = NULL;
diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h
index 996f561..40b9326 100644
--- a/include/linux/fcntl.h
+++ b/include/linux/fcntl.h
@@ -3,6 +3,10 @@
#include <asm/fcntl.h>
+/* Cancel a blocking posix lock; internal use only until we expose an
+ * asynchronous lock api to userspace: */
+#define F_CANCELLK (F_LINUX_SPECIFIC_BASE+5)
+
#define F_SETLEASE (F_LINUX_SPECIFIC_BASE+0)
#define F_GETLEASE (F_LINUX_SPECIFIC_BASE+1)
diff --git a/include/linux/lockd/bind.h b/include/linux/lockd/bind.h
index 01c25e4..1333dcf 100644
--- a/include/linux/lockd/bind.h
+++ b/include/linux/lockd/bind.h
@@ -41,5 +41,6 @@ extern void lockd_down(void);
extern int vfs_test_lock(struct file *, struct file_lock *, struct file_lock *);
extern int vfs_lock_file(struct file *, int cmd, struct file_lock *);
extern int vfs_lock_file_conf(struct file *, struct file_lock *, struct file_lock *);
+extern int vfs_cancel_lock(struct file *filp, struct file_lock *fl);
#endif /* LINUX_LOCKD_BIND_H */
--
1.5.0.rc1.g72fe
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@citi.umich.edu>
To: linux-fsdevel@vger.kernel.org
Cc: nfs@lists.sourceforge.net, Marc Eshel <eshel@almaden.ibm.com>
Subject: [PATCH 6/14] locks: add lock cancel command
Date: Sat, 3 Feb 2007 00:34:02 -0500 [thread overview]
Message-ID: <49315.8145611689$1170484083@news.gmane.org> (raw)
Message-ID: <fdf19cb6a33a08dd9220cdf2379d712d3c15e66f.1170479265.git.bfields@citi.umich.edu> (raw)
In-Reply-To: <11704808513070-git-send-email->
In-Reply-To: <ad8373acbb12f165b625f6065bc0ca86f3982b7f.1170479265.git.bfields@citi.umich.edu>
From: Marc Eshel <eshel@almaden.ibm.com> - unquoted
Lock managers need to be able to cancel pending lock requests. In the case
where the exported filesystem manages its own locks, it's not sufficient just
to call posix_unblock_lock(); we need to let the filesystem know what's
happening too.
We do this by adding a new fcntl lock command: FL_CANCELLK. Some day this
might also be made available to userspace applications that could benefit from
an asynchronous locking api.
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
---
fs/locks.c | 17 +++++++++++++++++
include/linux/fcntl.h | 4 ++++
include/linux/lockd/bind.h | 1 +
3 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 819dc28..8ee72b3 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2061,6 +2061,23 @@ posix_unblock_lock(struct file *filp, struct file_lock *waiter)
EXPORT_SYMBOL(posix_unblock_lock);
+/**
+ * vfs_cancel_lock - file byte range unblock lock
+ * @filp: The file to apply the unblock to
+ * @fl: The lock to be unblocked
+ *
+ * Used by lock managers to cancel blocked requests
+ */
+int vfs_cancel_lock(struct file *filp, struct file_lock *fl)
+{
+ if (filp->f_op && filp->f_op->lock)
+ return filp->f_op->lock(filp, F_CANCELLK, fl);
+ else
+ return posix_unblock_lock(filp, fl);
+}
+
+EXPORT_SYMBOL(vfs_cancel_lock);
+
static void lock_get_status(char* out, struct file_lock *fl, int id, char *pfx)
{
struct inode *inode = NULL;
diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h
index 996f561..40b9326 100644
--- a/include/linux/fcntl.h
+++ b/include/linux/fcntl.h
@@ -3,6 +3,10 @@
#include <asm/fcntl.h>
+/* Cancel a blocking posix lock; internal use only until we expose an
+ * asynchronous lock api to userspace: */
+#define F_CANCELLK (F_LINUX_SPECIFIC_BASE+5)
+
#define F_SETLEASE (F_LINUX_SPECIFIC_BASE+0)
#define F_GETLEASE (F_LINUX_SPECIFIC_BASE+1)
diff --git a/include/linux/lockd/bind.h b/include/linux/lockd/bind.h
index 01c25e4..1333dcf 100644
--- a/include/linux/lockd/bind.h
+++ b/include/linux/lockd/bind.h
@@ -41,5 +41,6 @@ extern void lockd_down(void);
extern int vfs_test_lock(struct file *, struct file_lock *, struct file_lock *);
extern int vfs_lock_file(struct file *, int cmd, struct file_lock *);
extern int vfs_lock_file_conf(struct file *, struct file_lock *, struct file_lock *);
+extern int vfs_cancel_lock(struct file *filp, struct file_lock *fl);
#endif /* LINUX_LOCKD_BIND_H */
--
1.5.0.rc1.g72fe
next prev parent reply other threads:[~2007-02-03 5:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11704808501171-git-send-email->
[not found] ` <11704808502512-git-send-email->
[not found] ` <11704808513862-git-send-email->
[not found] ` <1170480851972-git-send-email->
[not found] ` <11704808513070-git-send-email->
[not found] ` <117048085185-git-send-email->
[not found] ` <11704808513263-git-send-email->
[not found] ` <11704808513185-git-send-email->
[not found] ` <11704808511238-git-send-email->
[not found] ` <11704808513085-git-send-email->
[not found] ` <11704808521765-git-send-email->
[not found] ` <11704808523686-git-send-email->
[not found] ` <ad8373acbb12f165b625f6065bc0ca86f3982b7f.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:33 ` [PATCH 1/14] locks: always unlock on close J. Bruce Fields
2007-02-03 5:33 ` J. Bruce Fields
[not found] ` <5cdd83858bf5c75e14742bbd03b462f5ec4997fe.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:33 ` [PATCH 2/14] locks: factor out generic/filesystem switch from test_lock J. Bruce Fields
2007-02-03 5:33 ` J. Bruce Fields
2007-02-03 8:50 ` Christoph Hellwig
2007-02-04 1:48 ` J. Bruce Fields
2007-02-04 8:41 ` Christoph Hellwig
2007-02-04 0:32 ` [NFS] " Trond Myklebust
2007-02-04 1:52 ` J. Bruce Fields
[not found] ` <1dd47bf9aeb6f19c82a59efb2f4236f23f73019d.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:33 ` [PATCH 3/14] locks: factor out generic/filesystem switch from setlock code J. Bruce Fields
2007-02-03 5:33 ` J. Bruce Fields
2007-02-03 8:51 ` Christoph Hellwig
2007-02-03 5:16 ` Brad Boyer
2007-02-04 2:27 ` J. Bruce Fields
2007-02-04 8:37 ` Christoph Hellwig
2007-02-03 21:27 ` Brad Boyer
2007-02-04 1:58 ` J. Bruce Fields
[not found] ` <a4ecb8974d61a5077d24cf42ed2c564b4fa7aadf.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 5/14] locks: add fl_notify arguments for asynchronous lock return J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <fdf19cb6a33a08dd9220cdf2379d712d3c15e66f.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` J. Bruce Fields [this message]
2007-02-03 5:34 ` [PATCH 6/14] locks: add lock cancel command J. Bruce Fields
[not found] ` <d1c313156428c533721d67f938ca72759b192156.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 7/14] nfsd4: Convert NFSv4 to new lock interface J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <8096fc4eb11f5c5678197fdee8afe0e2780357fc.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 8/14] lockd: save lock state on deferral J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <6f2a40ca33ea2b58e3f515bea9be1e0fa8cda6aa.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 9/14] lockd: handle fl_notify callbacks J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
2007-02-04 0:40 ` [NFS] " Trond Myklebust
2007-02-04 2:10 ` J. Bruce Fields
[not found] ` <19e4ad761534f2afd8045321c950a9336c6b1fc2.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 10/14] lockd: pass cookie in nlmsvc_testlock J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <ecc19d4bdf659f8cd1bbe4783625af5040f0b83a.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 11/14] lockd: handle test_lock deferrals J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <ed8e1981069ef91a62c19a16b37d51c819a5196f.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 12/14] lockd: always preallocate block in nlmsvc_lock() J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <b18934dedc3dd49bd1578256944c8fb756db2a6c.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 13/14] lockd: add code to handle deferred lock requests J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <6d1e339108dad3e204a1eb53e736a2a0f73dda22.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 14/14] gfs2: nfs lock support for gfs2 J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
[not found] ` <96a0abaf64b433a7e7450e7e35d0baf2c44103db.1170479265.git.bfields@citi.umich.edu>
2007-02-03 5:34 ` [PATCH 4/14] locks: add locking function that returns conflicting lock J. Bruce Fields
2007-02-03 5:34 ` J. Bruce Fields
2007-02-03 8:54 ` Christoph Hellwig
2007-02-04 2:02 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6816.47257083586$1170480891@news.gmane.org' \
--to=bfields@citi.umich.edu \
--cc=eshel@almaden.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).