From: Eric Sandeen <sandeen@redhat.com>
To: David Howells <dhowells@redhat.com>,
torvalds@linux-foundation.org,
Miklos Szeredi <mszeredi@redhat.com>,
Ira Weiny <ira.weiny@intel.com>
Cc: linux-fsdevel@vger.kernel.org, linux-man@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: UAPI value collision: STATX_ATTR_MOUNT_ROOT vs STATX_ATTR_DAX
Date: Wed, 25 Nov 2020 13:32:45 -0600 [thread overview]
Message-ID: <fdf89cef-1350-e387-4d59-e6951255dbf0@redhat.com> (raw)
In-Reply-To: <1927370.1606323014@warthog.procyon.org.uk>
On 11/25/20 10:50 AM, David Howells wrote:
> Hi Linus, Miklos, Ira,
>
> It seems that two patches that got merged in the 5.8 merge window collided and
> no one noticed until now:
>
> 80340fe3605c0 (Miklos Szeredi 2020-05-14 184) #define STATX_ATTR_MOUNT_ROOT 0x00002000 /* Root of a mount */
> ...
> 712b2698e4c02 (Ira Weiny 2020-04-30 186) #define STATX_ATTR_DAX 0x00002000 /* [I] File is DAX */
>
> The question is, what do we do about it? Renumber one or both of the
> constants?
>
> David
Related to this, nothing sets STATX_ATTR_DAX into statx->attributes_mask,
anywhere in the kernel.
The flag is set into statx->attributes in vfs_getattr_nosec(), but that
does not know whether the particular filesystem under query supports dax
or not.
This is related to my other email about exactly what attributes_mask
means, so should STATX_ATTR_DAX be set in statx->attributes_mask only
in the filesystems that support dax?
(And should that be done only if CONFIG_DAX is turned on, etc?)
-Eric
next prev parent reply other threads:[~2020-11-25 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 16:50 UAPI value collision: STATX_ATTR_MOUNT_ROOT vs STATX_ATTR_DAX David Howells
2020-11-25 19:26 ` Miklos Szeredi
2020-11-26 3:00 ` Andreas Dilger
2020-11-25 19:32 ` Eric Sandeen [this message]
2020-11-25 20:44 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdf89cef-1350-e387-4d59-e6951255dbf0@redhat.com \
--to=sandeen@redhat.com \
--cc=dhowells@redhat.com \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).