From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] fs: kill unused ret2 argument from iocb->ki_complete()
Date: Wed, 20 Oct 2021 11:35:27 -0600 [thread overview]
Message-ID: <fe54edc2-da83-6dbb-cfb9-ad3a7fbe3780@kernel.dk> (raw)
In-Reply-To: <YXBSLweOk1he8DTO@infradead.org>
On 10/20/21 11:30 AM, Christoph Hellwig wrote:
> On Wed, Oct 20, 2021 at 10:49:07AM -0600, Jens Axboe wrote:
>> It's not used for anything, and we're wasting time passing in zeroes
>> where we could just ignore it instead. Update all ki_complete users in
>> the kernel to drop that last argument.
>>
>> The exception is the USB gadget code, which passes in non-zero. But
>> since nobody every looks at ret2, it's still pointless.
>
> Yes, the USB gadget passes non-zero, and aio passes that on to
> userspace. So this is an ABI change. Does it actually matter?
> I don't know, but you could CC the relevant maintainers and list
> to try to figure that out.
True, guess it does go out to userspace. Greg, is anyone using
it on the userspace side?
--
Jens Axboe
next prev parent reply other threads:[~2021-10-20 17:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 16:49 [PATCH] fs: kill unused ret2 argument from iocb->ki_complete() Jens Axboe
2021-10-20 17:30 ` Christoph Hellwig
2021-10-20 17:35 ` Jens Axboe [this message]
2021-10-20 17:49 ` Greg Kroah-Hartman
2021-10-21 16:40 ` John Keeping
2021-10-21 16:56 ` Jens Axboe
2021-10-22 15:44 ` Jens Axboe
2021-10-23 9:09 ` Greg Kroah-Hartman
2021-10-23 14:01 ` Jens Axboe
2021-10-20 18:16 ` Jeff Moyer
2021-10-20 18:21 ` Jens Axboe
2021-10-20 18:37 ` Jeff Moyer
2021-10-20 18:41 ` Jens Axboe
2021-10-20 18:56 ` Jens Axboe
2021-10-20 19:11 ` Jeff Moyer
2021-10-20 19:12 ` Jens Axboe
2021-10-20 19:47 ` Jeff Moyer
2021-10-20 19:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe54edc2-da83-6dbb-cfb9-ad3a7fbe3780@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).