From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FFDC63798 for ; Wed, 25 Nov 2020 06:10:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6D3B20B80 for ; Wed, 25 Nov 2020 06:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727718AbgKYGK0 (ORCPT ); Wed, 25 Nov 2020 01:10:26 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:7982 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbgKYGKZ (ORCPT ); Wed, 25 Nov 2020 01:10:25 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Cgr8c4ZrLzhYVP; Wed, 25 Nov 2020 14:10:08 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 25 Nov 2020 14:10:21 +0800 Subject: Re: [PATCH 30/45] block: remove the nr_sects field in struct hd_struct To: Christoph Hellwig , Jens Axboe CC: Tejun Heo , Josef Bacik , "Konrad Rzeszutek Wilk" , Coly Li , "Mike Snitzer" , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , , Richard Weinberger , Jan Kara , , , , , , References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-31-hch@lst.de> From: Chao Yu Message-ID: Date: Wed, 25 Nov 2020 14:10:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201124132751.3747337-31-hch@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2020/11/24 21:27, Christoph Hellwig wrote: > Now that the hd_struct always has a block device attached to it, there is > no need for having two size field that just get out of sync. > > Additional the field in hd_struct did not use proper serializiation, > possibly allowing for torn writes. By only using the block_device field > this problem also gets fixed. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Greg Kroah-Hartman > --- > block/bio.c | 4 +- > block/blk-core.c | 2 +- > block/blk.h | 53 ---------------------- > block/genhd.c | 55 +++++++++++----------- > block/partitions/core.c | 17 ++++--- > drivers/block/loop.c | 1 - > drivers/block/nbd.c | 2 +- > drivers/block/xen-blkback/common.h | 4 +- > drivers/md/bcache/super.c | 2 +- > drivers/s390/block/dasd_ioctl.c | 4 +- > drivers/target/target_core_pscsi.c | 7 +-- > fs/block_dev.c | 73 +----------------------------- > fs/f2fs/super.c | 2 +- For f2fs part, Acked-by: Chao Yu Thanks, > fs/pstore/blk.c | 2 +- > include/linux/genhd.h | 29 +++--------- > kernel/trace/blktrace.c | 2 +- > 16 files changed, 60 insertions(+), 199 deletions(-)