Linux filesystem development
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: Christian Brauner <brauner@kernel.org>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: [PATCH 0/2] fat: convert to the new mount API
Date: Sat, 29 Jun 2024 12:30:16 -0500	[thread overview]
Message-ID: <fe6baab2-a7a0-4fb0-9b94-17c58f73ed62@redhat.com> (raw)

This short series converts the fat/vfat/msdos filesystem to use the
new mount API.

I've tested it with a hacky shell script found at 

https://gist.github.com/sandeen/3492a39c3f2bf16d1ccdd2cd1c681ccd

which tries every possible option, including some with invalid values,
on both vfat and msdos mounts. It then tests random combinations of
2, 3, and 4 options, including possibly invalid options.

I captured stdout from two runs with and without these modifications,
and the results are identical.

As patch 2 notes, I left codepage loading to fill_super(), rather than
validating codepage options as they are parsed. This is because i.e.

mount -o "iocharset=nope,iocharset=iso8859-1"

passes today, due to the last iocharset option being the only one that is
loaded. It might be nice to validate such options as they are parsed, but
doing so would make the above command line fail, so I'm not sure if it's
a good idea. I do have a patch to validate as we parse, if that's desired.

Lastly, this does not yet use the proposed uid/gid parsing helpers, since
that is not yet merged.

Thanks,
-Eric


             reply	other threads:[~2024-06-29 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-29 17:30 Eric Sandeen [this message]
2024-06-29 17:31 ` [PATCH 1/2] fat: move debug into fat_mount_options Eric Sandeen
2024-06-29 17:32 ` [PATCH 2/2] fat: Convert to new mount api Eric Sandeen
2024-06-29 18:02   ` [PATCH 2/2 V2] " Eric Sandeen
2024-07-01 14:15     ` OGAWA Hirofumi
2024-07-01 17:35       ` Eric Sandeen
2024-07-01 20:20         ` Eric Sandeen
2024-07-02  5:04           ` OGAWA Hirofumi
2024-06-29 18:00 ` [PATCH 0/2] fat: convert to the new mount API Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe6baab2-a7a0-4fb0-9b94-17c58f73ed62@redhat.com \
    --to=sandeen@redhat.com \
    --cc=brauner@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox