From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Blunck Subject: Re: [patch 3/5] fuse: fix race in llseek Date: Mon, 28 Apr 2008 08:34:06 +0000 (UTC) Message-ID: References: <20080425175520.735386844@szeredi.hu> <20080425175657.912755144@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org To: linux-fsdevel@vger.kernel.org Return-path: Received: from main.gmane.org ([80.91.229.2]:35636 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764962AbYD1IeW (ORCPT ); Mon, 28 Apr 2008 04:34:22 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JqOoP-0002Cq-Fi for linux-fsdevel@vger.kernel.org; Mon, 28 Apr 2008 08:34:13 +0000 Received: from charybdis-ext.suse.de ([195.135.221.2]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 Apr 2008 08:34:13 +0000 Received: from jblunck by charybdis-ext.suse.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 Apr 2008 08:34:13 +0000 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 25 Apr 2008 19:55:23 +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Fuse doesn't use i_mutex to protect setting i_size, and so > generic_file_llseek() can be racy: it doesn't use i_size_read(). > > So do a fuse specific llseek method, which does use i_size_read(). > Is there any specific reason why we don't use i_size_read() in generic_file_llseek()? If no, why don't you fix it instead? Regards, Jan -- Jan Blunck