Re: [patch 3/5] fuse: fix race in llseek

Jan Blunck
2008-04-28T08:34:22Z

On Fri, 25 Apr 2008 19:55:23 +0200, Miklos Szeredi wrote:

> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Fuse doesn't use i_mutex to protect setting i_size, and so
> generic_file_llseek() can be racy: it doesn't use i_size_read().
>
> So do a fuse specific llseek method, which does use i_size_read().
>

Is there any specific reason why we don't use i_size_read() in
generic_file_llseek()? If no, why don't you fix it instead?

Regards,
Jan

--
Jan Blunck <jblunck@suse.de>