Re: [PATCH] ubifs: add update vfs super block infomation when remount to ro mode

[Zhang JieJing <kzjeef@gmail.com>]

(resend since HTML mail rejected by linux-fsdevel.)
Hi Artem,

I just clone the  git://git.infradead.org/ubifs-2.6.git, and git am my
patch, It is very clean patched, so, maybe your git repo code is very
new, so the patch can't cleaned apply.

This is my first patch give back to upstream, even I read the kernel
document 'how-to send patch' but still something leaked.
If I did something wrong, Please show me the right way or something like that,
Thanks for your time.

---
Best regards,
Zhang Jiejing



2010/4/28 Artem Bityutskiy <dedekind1@gmail.com>:
> On Fri, 2010-04-16 at 11:36 +0800, ZhangJieJing wrote:
>> If some read/write error happens(eg.CRC error), ubifs make self a read
>> only mode,
>> but the vfs infomation still not update.
>> This patch add this also make /proc/mounts update.
>>
>> Signed-off-by: Zhang Jiejing <kzjeef@gmail.com>
>> ---
>>  fs/ubifs/io.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>> diff --git a/fs/ubifs/io.c b/fs/ubifs/io.c
>> index 0168271..d33c233 100644
>> --- a/fs/ubifs/io.c
>> +++ b/fs/ubifs/io.c
>> @@ -63,6 +63,7 @@ void ubifs_ro_mode(struct ubifs_info *c, int err)
>>        if (!c->ro_media) {
>>                c->ro_media = 1;
>>                c->no_chk_data_crc = 0;
>> +              c->vfs_sb->s_flags |= MS_RDONLY;
>>                ubifs_warn("switched to read-only mode, error %d", err);
>>                dbg_dump_stack();
>>        }
>> --
>> 1.6.3.3
>
> Your patch is not applicable. Try to save your own e-mail and apply the
> patch with 'git am'.
>
> Applying: UBIFS: mark VFS SB RO too
> fatal: corrupt patch at line 9
> Patch failed at 0001 UBIFS: mark VFS SB RO too
> When you have resolved this problem run "git am -i --resolved".
> If you would prefer to skip this patch, instead run "git am -i --skip".
> To restore the original branch and stop patching run "git am -i
> --abort".
> [dedekind@sauron ubifs-2.6]\$ patch -p1 < .git/rebase-apply/patch
> patching file fs/ubifs/io.c
> patch: **** malformed patch at line 9: �� � � if (!c->ro_media) {
>
>
> But I've fixed this up and applied manually. It is now in the
> ubifs-2.6.git tree, thanks.
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html