From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [patch 1/3] mm: pagecache write deadlocks zerolength fix Date: Thu, 30 Nov 2006 11:30:33 +0100 Message-ID: References: <20061130072058.GA18004@wotan.suse.de> <20061130101933.GA12579@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Linux Kernel Mailing List , Andrew Morton , linux-fsdevel@vger.kernel.org Return-path: Received: from mail.suse.de ([195.135.220.2]:26578 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S934264AbWK3Kaf (ORCPT ); Thu, 30 Nov 2006 05:30:35 -0500 To: Nick Piggin In-Reply-To: <20061130101933.GA12579@wotan.suse.de> (Nick Piggin's message of "Thu, 30 Nov 2006 11:19:34 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Nick Piggin writes: > On Thu, Nov 30, 2006 at 11:15:39AM +0100, Andreas Schwab wrote: >> Nick Piggin writes: >>=20 >> > writev with a zero-length segment is a noop, and we shouldn't retu= rn EFAULT. >>=20 >> AFAICS the callers of these functions never pass a zero length. > > They can in the case of a zero length write. How? All (indirect) callers I could find explicitly handle the zero-length case. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4= ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html