public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab=l3A5Bk7waGM@public.gmane.org>
To: "J.A. Magallon" <jamagallon=cer70A47DaU@public.gmane.org>
Cc: Brad Boyer <flar=FRd/JmJGuRE@public.gmane.org>,
	Roman Zippel <zippel=Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
	linux-hfsplus-devel=5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-fsdevel=u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel=u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [ANNOUNCE] HFS+ driver
Date: Mon, 12 May 2003 11:58:59 +0200	[thread overview]
Message-ID: <jeissglc4c.fsf@sykes.suse.de> (raw)
In-Reply-To: <20030508221202.GE3458@werewolf.able.es> (J. A. Magallon's message of "Fri, 9 May 2003 00:12:02 +0200")

"J.A. Magallon" <jamagallon=cer70A47DaU@public.gmane.org> writes:

|> Modified version, including the hfsplus dir and the 64 bit changes, is at
|> http://giga.cps.unizar.es/~magallon/linux/hfsplus-20030507-2.bz2

There is a warning in btree.c:hfsplus_btree_alloc_node.  Does this make
sense?

--- btree.c.~1~	2003-05-12 11:53:42.000000000 +0200
+++ btree.c	2003-05-12 11:53:51.000000000 +0200
@@ -204,7 +204,7 @@ hfsplus_bnode *hfsplus_btree_alloc_node(
 					}
 				}
 			}
-			if (++off >= PAGE_CACHE_MASK) {
+			if (++off >= PAGE_CACHE_SIZE) {
 				hfsplus_kunmap(*pagep++);
 				data = hfsplus_kmap(*pagep);
 				off = 0;

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab=l3A5Bk7waGM@public.gmane.org
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


-------------------------------------------------------
Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
The only event dedicated to issues related to Linux enterprise solutions
www.enterpriselinuxforum.com

      parent reply	other threads:[~2003-05-12  9:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-07 15:06 [ANNOUNCE] HFS+ driver Roman Zippel
2003-05-07 15:40 ` David S. Miller
2003-05-07 19:39 ` Brad Boyer
2003-05-07 23:53   ` Roman Zippel
2003-05-08 21:34 ` J.A. Magallon
2003-05-08 21:47   ` Brad Boyer
2003-05-08 22:12     ` J.A. Magallon
2003-05-08 22:50       ` Brad Boyer
2003-05-12  9:58       ` Andreas Schwab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jeissglc4c.fsf@sykes.suse.de \
    --to=schwab=l3a5bk7wagm@public.gmane.org \
    --cc=flar=FRd/JmJGuRE@public.gmane.org \
    --cc=jamagallon=cer70A47DaU@public.gmane.org \
    --cc=linux-fsdevel=u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-hfsplus-devel=5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-kernel=u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=zippel=Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox