From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE Date: Wed, 11 Jul 2012 06:07:32 +0000 (UTC) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org,linux-kernel@vger.kernel.org To: linux-mm@kvack.org Return-path: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins wrote: > Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"). > I believe it's correct, and it's been nice to have from rc1 to rc6; > but as the original commit said: > > I don't know who actually uses SEEK_DATA or SEEK_HOLE, and whether it > would be of any use to them on tmpfs. This code adds 92 lines and 752 > bytes on x86_64 - is that bloat or worthwhile? I don't think 752 bytes matter much, especially for x86_64. > > Nobody asked for it, so I conclude that it's bloat: let's revert tmpfs > to the dumb generic support for v3.5. We can always reinstate it later > if useful, and anyone needing it in a hurry can just get it out of git. > If you don't have burden to maintain it, I'd prefer to leave as it is, I don't think 752-bytes is the reason we revert it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org