From: Florian Weimer <fweimer@redhat.com>
To: hch <hch@lst.de>
Cc: Hans Holmberg <Hans.Holmberg@wdc.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Carlos Maiolino <cem@kernel.org>,
Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <djwong@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [RFC] xfs: fake fallocate success for always CoW inodes
Date: Tue, 11 Nov 2025 10:50:13 +0100 [thread overview]
Message-ID: <lhu4ir0kiei.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20251111090547.GC11723@lst.de> (hch@lst.de's message of "Tue, 11 Nov 2025 10:05:47 +0100")
> On Tue, Nov 11, 2025 at 08:31:30AM +0000, Hans Holmberg wrote:
>> In stead of returning success in fallocate(2), could we in stead return
>> an distinct error code that would tell the caller that:
>>
>> The optimized allocation not supported, AND there is no use trying to
>> preallocate data using writes?
>>
>> EUSELESS would be nice to have, but that is not available.
>>
>> Then posix_fallocate could fail with -EINVAL (which looks legit according
>> to the man page "the underlying filesystem does not support the operation")
>> or skip the writes and return success (whatever is preferable)
>
> The problem is that both the existing direct callers of fallocate(2)
> including all currently released glibc versions do not expect that
> return value.
That could be covered by putting a flag into the mode argument of
allocate that triggers the new behavior.
Thanks,
Florian
next prev parent reply other threads:[~2025-11-11 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 13:35 [RFC] xfs: fake fallocate success for always CoW inodes Hans Holmberg
2025-11-06 13:48 ` Florian Weimer
2025-11-06 13:52 ` Christoph Hellwig
2025-11-06 14:42 ` Matthew Wilcox
2025-11-06 14:46 ` Christoph Hellwig
2025-11-11 8:31 ` Hans Holmberg
2025-11-11 9:05 ` hch
2025-11-11 9:50 ` Florian Weimer [this message]
2025-11-11 13:40 ` hch
2025-11-06 16:31 ` Florian Weimer
2025-11-06 17:05 ` Christoph Hellwig
2025-11-08 12:30 ` Florian Weimer
2025-11-09 22:15 ` Dave Chinner
2025-11-10 5:27 ` Florian Weimer
2025-11-10 9:38 ` Christoph Hellwig
2025-11-10 10:03 ` Florian Weimer
2025-11-10 20:28 ` Dave Chinner
2025-11-11 8:56 ` Christoph Hellwig
2025-11-10 9:37 ` Christoph Hellwig
2025-11-10 9:44 ` Florian Weimer
2025-11-10 21:33 ` Dave Chinner
2025-11-11 9:04 ` Christoph Hellwig
2025-11-11 9:30 ` Florian Weimer
2025-11-10 9:31 ` Christoph Hellwig
2025-11-10 9:48 ` truncatat? was, " Christoph Hellwig
2025-11-10 10:00 ` Florian Weimer
2025-11-10 9:49 ` Florian Weimer
2025-11-10 9:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lhu4ir0kiei.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=Hans.Holmberg@wdc.com \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).