From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 22/29] sysctl: Stop requiring explicit management of sysctl directories Date: Mon, 30 Jan 2012 20:45:02 -0800 Message-ID: References: <1327639925-12920-22-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, Damien Millescamps To: Lucian Adrian Grijincu Return-path: In-Reply-To: (Lucian Adrian Grijincu's message of "Sun, 29 Jan 2012 21:31:41 +0200") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Lucian Adrian Grijincu writes: > > Why do you only check the given @set after creating the new dir. Why > not the parent dir too? That is a race and a minor bug. Somehow I had convinced myself that either it didn't matter or that it would be hard to deal with, but that doesn't hold up. Oops. Thankfully the final version using links does not have this race/bug. Eric