Re: [patch 2/8] allow unprivileged umount

H. Peter Anvin
2007-04-21T08:05:34Z

Andrew Morton wrote:
> On Fri, 20 Apr 2007 12:25:34 +0200 Miklos Szeredi <miklos@szeredi.hu> wrote:
>
>> +static bool permit_umount(struct vfsmount *mnt, int flags)
>> +{
>>
>> ...
>>
>> + return mnt->mnt_uid == current->uid;
>> +}
>
> Yes, this seems very wrong. I'd have thought that comparing user_struct*'s
> would get us a heck of a lot closer to being able to support aliasing of
> UIDs between different namespaces.
>

Not to mention it should be fsuid, not uid.

-hpa