Re: [patch 3/8] account user mounts

Miklos Szeredi
2007-04-22T07:11:47Z

> > From: Miklos Szeredi <mszeredi@suse.cz>
> >
> > Add sysctl variables for accounting and limiting the number of user
> > mounts.
> >
> > The maximum number of user mounts is set to 1024 by default. This
> > won't in itself enable user mounts, setting a mount to be owned by a
> > user is first needed
>
> Since each mount has a user can we just make this a per user rlimit?
>
> If we are going to implement a sysctl at this point I think it should
> be a global limit that doesn't care if who you are. Even root can
> have recursive mounts that attempt to get out of control.

Recursive bind mounts are done carefully enough, so they don't get out
of control.

Recursive mount propagations can get out of control. But root can
shoot itself in the foot any number of ways, and it's not for the
kernel to police that.

> Also currently you are not checking the max_users. It looks like
> you do this in a later patch but still it is a little strange to
> allow user own mounts and have accounting but to not check the
> limit at this state.

Yeah, but at this stage user mounts are not yet allowed, so this is
safe.

Miklos