From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: symlinks with permissions Date: Fri, 30 Oct 2009 16:03:36 -0700 Message-ID: References: <20091026174631.GD7233@duck.suse.cz> <1256579869.8576.7.camel@heimdal.trondhjem.org> <20091025093604.GA1501@ucw.cz> <20091028081653.GA18290@elf.ucw.cz> <20091028210323.GA4159@elf.ucw.cz> <20091029110344.GA1517@ucw.cz> <20091030183559.GF7008@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Trond Myklebust , Jan Kara , "J. Bruce Fields" , "Serge E. Hallyn" , kernel list , linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jamie@shareable.org To: Pavel Machek Return-path: In-Reply-To: <20091030183559.GF7008@elf.ucw.cz> (Pavel Machek's message of "Fri\, 30 Oct 2009 19\:35\:59 +0100") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Pavel Machek writes: >> >> I certainly am not interested in debugging or maintaining the stacking >> >> inode code that would be necessary to close this theoretical corner >> >> case. There are much more real bugs that need attention. >> > >> > But if we can get trivial 10-liner, that should be acceptable, right? >> >> How many linux shell scripts and other applications that use /dev/fd/N >> or /proc/self/fd/N will you be breaking? > > Zero. (Well unless someone is exploiting it in wild). There are other differences like different offsets etc that may matter. >> Closing a theoretical security hole at the expense of breaking real >> applications is a show stopper. > > I don't plan to remove /proc/*/fd; but I would like it to behave like > dup(). > > (I still hope some security team does work for me :-). Seriously turning this into dup is about 20 lines of code in follow link. Just look at the open intent in the nameidata. nfs should have an exampled of using the open intent somewhere. I bet you will get a lot more traction and discussion if you write a basic mostly working version of the patch. Eric