From: Andi Kleen <andi@firstfloor.org>
To: Alex Davis <alex14641@yahoo.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Possible coding issue in udf??
Date: Sun, 15 May 2011 08:14:02 -0700 [thread overview]
Message-ID: <m2k4dsnghx.fsf@firstfloor.org> (raw)
In-Reply-To: <367853.39582.qm@web130121.mail.mud.yahoo.com> (Alex Davis's message of "Fri, 13 May 2011 19:57:20 -0700 (PDT)")
Alex Davis <alex14641@yahoo.com> writes:
> In fs/udf/inode.c, line 1455, linux 2.6.35, there is the following code:
>
> udfperms = ((inode->i_mode & S_IRWXO)) |
> ((inode->i_mode & S_IRWXG) << 2) |
> ((inode->i_mode & S_IRWXU) << 4);
>
> Shouldn't we be shifting by 3 bits? i.e:
> udfperms = ((inode->i_mode & S_IRWXO)) |
> ((inode->i_mode & S_IRWXG) << 3) |
> ((inode->i_mode & S_IRWXU) << 6);
>
> The S_I.. constants are all defined in include/linux/stat.h as 3-bit values.
>
> I will send a patch if needed.
I would suggest you test it first. Put in a UDF disk that triggers
this case (verify with a printk). Check in ls -l if the
permissions are correct or wrong.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-05-15 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 2:57 Possible coding issue in udf?? Alex Davis
2011-05-15 15:14 ` Andi Kleen [this message]
2011-05-15 16:29 ` Eric Dumazet
2011-05-15 16:32 ` Andreas Dilger
2011-05-15 17:15 ` Andreas Schwab
2011-05-15 17:13 ` Andreas Schwab
2011-05-15 18:04 ` Alex Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k4dsnghx.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=alex14641@yahoo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).