From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Tomas Subject: Re: [PATCH 1/9] extents for ext4 Date: Thu, 10 Aug 2006 23:05:14 +0400 Message-ID: References: <1155172827.3161.80.camel@localhost.localdomain> <20060809233940.50162afb.akpm@osdl.org> <20060810104954.0e03c83e.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, cmm@us.ibm.com, linux-fsdevel@vger.kernel.org, Alex Tomas Return-path: To: "Randy.Dunlap" In-Reply-To: <20060810104954.0e03c83e.rdunlap@xenotime.net> (Randy Dunlap's message of "Thu, 10 Aug 2006 10:49:54 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org >>>>> Randy Dunlap (RD) writes: RD> On Thu, 10 Aug 2006 13:29:56 +0400 Alex Tomas wrote: >> >>>>> Andrew Morton (AM) writes: >> >> >> From a quick scan: >> AM> - The code is very poorly commented. I'd want to spend a lot of time AM> reviewing this implementation, but not in its present state. >> >> what sort of comments are you expecting? RD> Helpful ones. Not obvious stuff. Intents. RD> Tricks used (if they are the right thing to do). RD> How, what, why. But not nitty-gritty details of how. RD> "Why" is often more important. well, it's a simple b+tree and i'm not sure there are ticks in. I'll try to re-read them again WRT what you wrote. AM> - The existing comments could benefit from some rework by a native English AM> speaker. >> >> could someone assist here, please? RD> Yes. How would you like it? Just comments via email or (quilt) patches? RD> Which files/patches? please, have a look at ext4-extents.patch first thanks, Alex ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642