linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: linux-fsdevel@vger.kernel.org
Cc: akpm@linux-foundation.org
Subject: [RFC PATCH 0 of 8] O_DIRECT locking rework
Date: Tue, 06 Feb 2007 20:32:45 -0400	[thread overview]
Message-ID: <patchbomb.1170811965@opti.oraclecorp.com> (raw)

Hello everyone,

Here's a respin of the O_DIRECT locking changes.  There are some minor
updates, mostly cleanups based on suggestions from Zach Brown and Dave
Chinner.

Linus found a deadlock between the placeholders and the page fault handler
when userland uses an mmap of the file as the O_DIRECT buffer.  I'm
getting around that by capping placeholder extents at DIO_PAGES (64)
intervals when the file has mappings.  This matches the interval used by
get_user_pages and makes sure get_user_pages has been called on a given
range in the address space before placeholders are added.

I also hit a stale data exposure when get_block returns data past the
end of the placeholder extent.  A concurrent readpage could come in and
find metadata before the data had gotten to disk.  The fix is to
only ask get_block for data up to the end of the placeholder.

Generally, this isn't a problem because the common case is for
a single placeholder to cover the entire DIO.  So the suboptimal
allocation result wouldn't happen very often.

-chris


             reply	other threads:[~2007-02-07 15:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07  0:32 Chris Mason [this message]
2007-02-07  0:32 ` [PATCH 1 of 8] Introduce a place holder page for the pagecache Chris Mason
2007-02-07 17:36   ` Zach Brown
2007-02-07  0:32 ` [PATCH 2 of 8] Change O_DIRECT to use placeholders instead of i_mutex/i_alloc_sem locking Chris Mason
2007-02-07 20:11   ` Zach Brown
2007-02-07 20:22     ` Chris Mason
2007-02-07 20:34       ` Zach Brown
2007-02-07  0:32 ` [PATCH 3 of 8] DIO: don't fall back to buffered writes Chris Mason
2007-02-07  0:32 ` [PATCH 4 of 8] Add flags to control direct IO helpers Chris Mason
2007-02-07 17:08   ` Suparna Bhattacharya
2007-02-07 18:05     ` Chris Mason
2007-02-08  4:03       ` Suparna Bhattacharya
2007-02-08 12:58         ` Chris Mason
2007-02-07  0:32 ` [PATCH 5 of 8] Make ext3 safe for the new DIO locking rules Chris Mason
2007-02-07  0:32 ` [PATCH 6 of 8] Make reiserfs safe for " Chris Mason
2007-02-07  0:32 ` [PATCH 7 of 8] Adapt XFS to the new blockdev_direct_IO calls Chris Mason
2007-02-07  0:32 ` [PATCH 8 of 8] Avoid too many boundary buffers in DIO Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=patchbomb.1170811965@opti.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).