From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: Alexander Viro <viro@math.psu.edu>, linux-fsdevel@vger.kernel.org
Subject: Re: 2 questions concerning vfs_rmdir() (2.4.x and 2.5.x)
Date: 23 Aug 2002 11:24:32 +0200 [thread overview]
Message-ID: <shsbs7uudv3.fsf@charged.uio.no> (raw)
In-Reply-To: <20020822150511.GB1666@ravel.coda.cs.cmu.edu>
>>>>> " " == Jan Harkes <jaharkes@cs.cmu.edu> writes:
> Worst case scenario is that the underlying FS receives a new
> lookup for the entry. Probably very useful when the dcache is
> slightly out of sync.
But severely fscked up if the dentry is a mountpoint.
> The rmdir might have failed because the directory doesn't exist
> in the filesystem, so rehashing the dentry would be wrong.
Where's the big deal?
Either the dentry wasn't hashed in the first place (in which case a
simple test before you call d_unhash() can be used to tell you not to
rehash) or you will in any case need to have code in
lookup_revalidate() to cope with the alternative case "I've got a
hashed dentry that doesn't exist in the filesystem and I didn't call
rmdir()".
Cheers,
Trond
prev parent reply other threads:[~2002-08-23 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-22 13:48 2 questions concerning vfs_rmdir() (2.4.x and 2.5.x) Trond Myklebust
2002-08-22 15:05 ` Jan Harkes
2002-08-23 9:24 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsbs7uudv3.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox