Linux filesystem development
 help / color / mirror / Atom feed
From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com
Cc: dakr@kernel.org, gregkh@linuxfoundation.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	rafael@kernel.org, syzkaller-bugs@googlegroups.com
Subject: [PATCH] debugfs: add fsd's methods initialization
Date: Mon,  3 Feb 2025 11:27:56 +0800	[thread overview]
Message-ID: <tencent_8D66623CFF36BA96EE36FE4B7474B1778509@qq.com> (raw)
In-Reply-To: <679f72f6.050a0220.48cbc.000d.GAE@google.com>

syzbot reported a uninit-value in full_proxy_unlocked_ioctl. [1]

The newly created fsd does not initialize methods, and increases the
initialization of methods for fsd.

[1]
BUG: KMSAN: uninit-value in full_proxy_unlocked_ioctl+0xed/0x3a0 fs/debugfs/file.c:399
 full_proxy_unlocked_ioctl+0xed/0x3a0 fs/debugfs/file.c:399
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:906 [inline]
 __se_sys_ioctl+0x246/0x440 fs/ioctl.c:892
 __x64_sys_ioctl+0x96/0xe0 fs/ioctl.c:892
 x64_sys_call+0x19f0/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:17
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Fixes: 41a0ecc0997c ("debugfs: get rid of dynamically allocation proxy_ops")
Reported-by: syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=8928e473a91452caca2f
Tested-by: syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
---
 fs/debugfs/file.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index e33cc77699cd..5fbefce2b372 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -102,6 +102,7 @@ static int __debugfs_file_get(struct dentry *dentry, enum dbgfs_get_mode mode)
 		if (!fsd)
 			return -ENOMEM;
 
+		fsd->methods = 0;
 		if (mode == DBGFS_GET_SHORT) {
 			const struct debugfs_short_fops *ops;
 			ops = fsd->short_fops = DEBUGFS_I(inode)->short_fops;
-- 
2.43.0


  reply	other threads:[~2025-02-03  3:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-02 13:28 [syzbot] [fs?] KMSAN: uninit-value in full_proxy_unlocked_ioctl syzbot
2025-02-03  3:27 ` Edward Adam Davis [this message]
2025-02-03  8:14   ` [PATCH] debugfs: add fsd's methods initialization Greg KH
2025-02-03 11:05     ` Edward Adam Davis
2025-02-03 11:27       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_8D66623CFF36BA96EE36FE4B7474B1778509@qq.com \
    --to=eadavis@qq.com \
    --cc=dakr@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox