From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+41ba9c82bce8d7101765@syzkaller.appspotmail.com
Cc: frank.li@vivo.com, glaubitz@physik.fu-berlin.de,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
slava@dubeyko.com, syzkaller-bugs@googlegroups.com
Subject: [PATCH] hfs: Prevent the use of bnodes without entries
Date: Thu, 24 Jul 2025 23:08:26 +0800 [thread overview]
Message-ID: <tencent_DFFF86C192DEC64EC99B6EF96EDE4C986706@qq.com> (raw)
In-Reply-To: <68811963.050a0220.248954.0005.GAE@google.com>
If the number of entries in the bnode is 0, the bnode is considered
invalid.
Reported-by: syzbot+41ba9c82bce8d7101765@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=41ba9c82bce8d7101765
Tested-by: syzbot+41ba9c82bce8d7101765@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
---
fs/hfs/bfind.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/hfs/bfind.c b/fs/hfs/bfind.c
index ef9498a6e88a..1d6f2bbafa7a 100644
--- a/fs/hfs/bfind.c
+++ b/fs/hfs/bfind.c
@@ -133,6 +133,8 @@ int hfs_brec_find(struct hfs_find_data *fd)
goto invalid;
if (bnode->type != (--height ? HFS_NODE_INDEX : HFS_NODE_LEAF))
goto invalid;
+ if (!bnode->num_recs)
+ goto invalid;
bnode->parent = parent;
res = __hfs_brec_find(bnode, fd);
--
2.43.0
next prev parent reply other threads:[~2025-07-24 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 17:18 [syzbot] [hfs?] KASAN: out-of-bounds Read in hfs_bnode_move syzbot
2025-07-23 17:26 ` Viacheslav Dubeyko
2025-07-24 15:08 ` Edward Adam Davis [this message]
2025-07-24 20:06 ` [PATCH] hfs: Prevent the use of bnodes without entries Viacheslav Dubeyko
2025-08-27 9:54 ` [syzbot] [hfs?] KASAN: out-of-bounds Read in hfs_bnode_move syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_DFFF86C192DEC64EC99B6EF96EDE4C986706@qq.com \
--to=eadavis@qq.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=syzbot+41ba9c82bce8d7101765@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).