From: tip-bot for Lance Roy <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: paulmck@linux.ibm.com, linux-fsdevel@vger.kernel.org,
ldr709@gmail.com, hpa@zytor.com, mingo@kernel.org,
viro@zeniv.linux.org.uk, tglx@linutronix.de
Subject: [tip:core/rcu] userfaultfd: Replace spin_is_locked() with lockdep
Date: Tue, 4 Dec 2018 14:34:54 -0800 [thread overview]
Message-ID: <tip-456a737896b25e4853bbf3d6ca5a1c8ee4df4ee9@git.kernel.org> (raw)
Commit-ID: 456a737896b25e4853bbf3d6ca5a1c8ee4df4ee9
Gitweb: https://git.kernel.org/tip/456a737896b25e4853bbf3d6ca5a1c8ee4df4ee9
Author: Lance Roy <ldr709@gmail.com>
AuthorDate: Thu, 4 Oct 2018 23:45:44 -0700
Committer: Paul E. McKenney <paulmck@linux.ibm.com>
CommitDate: Mon, 12 Nov 2018 09:06:22 -0800
userfaultfd: Replace spin_is_locked() with lockdep
lockdep_assert_held() is better suited to checking locking requirements,
since it only checks if the current thread holds the lock regardless of
whether someone else does. This is also a step towards possibly removing
spin_is_locked().
Signed-off-by: Lance Roy <ldr709@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
---
fs/userfaultfd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index 356d2b8568c1..681881dc8a9d 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -926,7 +926,7 @@ static inline struct userfaultfd_wait_queue *find_userfault_in(
wait_queue_entry_t *wq;
struct userfaultfd_wait_queue *uwq;
- VM_BUG_ON(!spin_is_locked(&wqh->lock));
+ lockdep_assert_held(&wqh->lock);
uwq = NULL;
if (!waitqueue_active(wqh))
reply other threads:[~2018-12-04 22:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-456a737896b25e4853bbf3d6ca5a1c8ee4df4ee9@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=ldr709@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox