From: Jeff Moyer <jmoyer@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Dima Tisnek <dimaqq@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>, <amethyst623@163.com>,
USB list <linux-usb@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: mount stuck, khubd blocked
Date: Mon, 23 Jul 2012 15:22:19 -0400 [thread overview]
Message-ID: <x49394ith90.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1207231505520.1633-100000@iolanthe.rowland.org> (Alan Stern's message of "Mon, 23 Jul 2012 15:07:24 -0400 (EDT)")
Alan Stern <stern@rowland.harvard.edu> writes:
> On Wed, 20 Jun 2012, Jeff Moyer wrote:
>
>> Alan Stern <stern@rowland.harvard.edu> writes:
>>
>> > On Tue, 19 Jun 2012, Dima Tisnek wrote:
>> >
>> >> I made a microsd flash with 2 partitions, sdb1 is data partition, and
>> >> sdb2 is a sentinel partition, 1 block in size.
>> >>
>> >> I attached the usb-microsd reader with that card in it and by mistake
>> >> tried to mount the sentinel partition, I ran:
>> >> mount /dev/sdb2 /mnt/flash/
>> >>
>> >> mount got stuck, I was not able to kill or strace it, I pulled the usb
>> >> reader from the port, mount was still stuck, here's the dmesg log:
>>
>> Hi, Dima,
>>
>> Could you try the following patch?
>>
>> Thanks,
>> Jeff
>>
>> diff --git a/fs/buffer.c b/fs/buffer.c
>> index 838a9cf..769b30b 100644
>> --- a/fs/buffer.c
>> +++ b/fs/buffer.c
>> @@ -930,7 +930,7 @@ init_page_buffers(struct page *page, struct block_device *bdev,
>> bh->b_blocknr = block;
>> if (uptodate)
>> set_buffer_uptodate(bh);
>> - if (block < end_block)
>> + if (block <= end_block)
>> set_buffer_mapped(bh);
>> }
>> block++;
>
> Jeff, does this also fix Bugzilla #43269?
First, this patch is wrong. I posted another version later on that got
merged for 3.5.
As for bug 43269, it does not look like the same symptoms, so I would
not expect the patches I posted to resolve that issue. Sorry.
Cheers,
Jeff
next prev parent reply other threads:[~2012-07-23 19:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGGBzX+uGFOXb0WMD-bkDSL8nq=rD4ZFiV=xwAJyqNx=rZ20sw@mail.gmail.com>
2012-06-19 14:45 ` mount stuck, khubd blocked Alan Stern
2012-06-19 21:41 ` Dave Chinner
2012-06-20 14:31 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1206201020450.1804-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-06-21 1:34 ` Dave Chinner
2012-06-21 14:25 ` Alan Stern
2012-06-22 3:22 ` Dave Chinner
2012-06-22 14:32 ` Alan Stern
2012-06-20 18:47 ` Jeff Moyer
2012-07-23 19:07 ` Alan Stern
2012-07-23 19:22 ` Jeff Moyer [this message]
[not found] ` <x49394ith90.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2012-07-23 19:57 ` Alan Stern
2012-07-23 20:19 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49394ith90.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=amethyst623@163.com \
--cc=axboe@kernel.dk \
--cc=dimaqq@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).