From: Jeff Moyer <jmoyer@redhat.com>
To: Zach Brown <zach.brown@oracle.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org
Subject: Re: [PATCH take2 0/5] dio: clean up completion phase of direct_io_worker()
Date: Tue, 03 Oct 2006 17:47:08 -0400 [thread overview]
Message-ID: <x494pul842r.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20061002232119.18827.96966.sendpatchset@tetsuo.zabbo.net> (Zach Brown's message of "Mon, 2 Oct 2006 16:21:19 -0700 (PDT)")
==> Regarding [PATCH take2 0/5] dio: clean up completion phase of direct_io_worker(); Zach Brown <zach.brown@oracle.com> adds:
zach.brown> Andrew, testing has now uncovered 2 bugs in this patch set that
zach.brown> have been fixed. XFS and the generic file path were using
zach.brown> blkdev_direct_IO()'s return code to test if ops were in flight
zach.brown> and were missing EIOCBQUEUD. They've been fixed. I think this
zach.brown> can bake in -mm now.
zach.brown> Here's the initial introduction to the series with an update on
zach.brown> what's been tested:
zach.brown> There have been a lot of bugs recently due to the way
zach.brown> direct_io_worker() tries to decide how to finish direct IO
zach.brown> operations. In the worst examples it has failed to call
zach.brown> aio_complete() at all (hang) or called it too many times
zach.brown> (oops).
zach.brown> This set of patches cleans up the completion phase with the
zach.brown> goal of removing the complexity that lead to these bugs. We
zach.brown> end up with one path that calculates the result of the
zach.brown> operation after all off the bios have completed. We decide
zach.brown> when to generate a result of the operation using that path
zach.brown> based on the final release of a refcount on the dio structure.
zach.brown> I tried to progress towards the final state in steps that were
zach.brown> relatively easy to understand. Each step should compile but I
zach.brown> only tested the final result of having all the patches applied.
zach.brown> I've tested these on low end PC drives with aio-stress, the
zach.brown> direct IO tests I could manage to get running in LTP, orasim,
zach.brown> and some home-brew functional tests.
zach.brown> In http://lkml.org/lkml/2006/9/21/103 IBM reports success with
zach.brown> ext2 and ext3 running DIO LTP tests. They found that XFS bug
zach.brown> which has since been addressed in the patch series.
We tested this on one of our smaller systems using ext3, and it holds up.
There was no performance degradation observed. I would like to see some
raw testing; I'll see if I can't get that done.
As with the last posting, I reviewed the direct I/O path with the patches
applied, and it's much nicer than before.
Acked-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2006-10-03 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-02 23:21 [PATCH take2 0/5] dio: clean up completion phase of direct_io_worker() Zach Brown
2006-10-02 23:21 ` [PATCH take2 1/5] dio: centralize completion in dio_complete() Zach Brown
2006-10-03 22:26 ` Andrew Morton
2006-10-03 23:05 ` Zach Brown
2006-10-02 23:21 ` [PATCH take2 2/5] dio: call blk_run_address_space() once per op Zach Brown
2006-10-02 23:21 ` [PATCH take2 3/5] dio: formalize bio counters as a dio reference count Zach Brown
2006-10-03 22:44 ` Andrew Morton
2006-10-03 23:23 ` Zach Brown
2006-10-02 23:21 ` [PATCH take2 4/5] dio: remove duplicate bio wait code Zach Brown
2006-10-02 23:21 ` [PATCH take2 5/5] dio: only call aio_complete() after returning -EIOCBQUEUED Zach Brown
2006-10-03 21:47 ` Jeff Moyer [this message]
2006-10-03 22:20 ` [PATCH take2 0/5] dio: clean up completion phase of direct_io_worker() Andrew Morton
2006-10-03 23:00 ` Zach Brown
2006-10-04 10:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x494pul842r.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).