From: Jeff Moyer <jmoyer@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Dmitry Monakhov <dmonakhov@openvz.org>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH 2/2] blkdev: Simple cleanup in blkdev_issue_zeroout()
Date: Wed, 27 Apr 2011 10:05:42 -0400 [thread overview]
Message-ID: <x4962pz4wnd.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: 1303303172-22404-2-git-send-email-lczerner@redhat.com
Lukas Czerner <lczerner@redhat.com> writes:
> In blkdev_issue_zeroout() we are submitting regular WRITE bios, so we do
> not need to check for -EOPNOTSUPP specifically in case of error. Also
> there is no need to have label submit: because there is no way to jump
> out from the while cycle without an error and we really want to exit,
> rather than try again.
Looks good. While we're at it:
while (nr_sects != 0) {
sz = min((sector_t) PAGE_SIZE >> 9 , nr_sects);
if (sz == 0)
/* bio has maximum size possible */
break;
how could sz be equal to zero there?
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Cheers,
Jeff
next prev parent reply other threads:[~2011-04-27 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 12:39 [PATCH 1/2] blkdev: Submit discard bio in batches in blkdev_issue_discard() Lukas Czerner
2011-04-20 12:39 ` [PATCH 2/2] blkdev: Simple cleanup in blkdev_issue_zeroout() Lukas Czerner
2011-04-27 14:05 ` Jeff Moyer [this message]
2011-04-27 13:57 ` [PATCH 1/2] blkdev: Submit discard bio in batches in blkdev_issue_discard() Jeff Moyer
2011-04-28 7:57 ` Lukas Czerner
2011-04-28 8:09 ` Lukas Czerner
2011-04-28 13:29 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x4962pz4wnd.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=jens.axboe@oracle.com \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).