From: Jeff Moyer <jmoyer@redhat.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aio: check return value of create_workqueue()
Date: Mon, 13 Dec 2010 10:58:08 -0500 [thread overview]
Message-ID: <x4962uxd5rj.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1292252785-3683-1-git-send-email-namhyung@gmail.com> (Namhyung Kim's message of "Tue, 14 Dec 2010 00:06:25 +0900")
Namhyung Kim <namhyung@gmail.com> writes:
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> fs/aio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 8c8f6c5b6d79..c56153f5f73e 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -87,7 +87,7 @@ static int __init aio_setup(void)
>
> aio_wq = create_workqueue("aio");
> abe_pool = mempool_create_kmalloc_pool(1, sizeof(struct aio_batch_entry));
> - BUG_ON(!abe_pool);
> + BUG_ON(!aio_wq || !abe_pool);
>
> pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page));
Acked-by: Jeff Moyer <jmoyer@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
prev parent reply other threads:[~2010-12-13 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 15:06 [PATCH] aio: check return value of create_workqueue() Namhyung Kim
2010-12-13 15:58 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x4962uxd5rj.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).