From: Jeff Moyer <jmoyer@redhat.com>
To: Edward Shishkin <edward.shishkin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>,
lmcilroy@redhat.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/2] vfs: fix overflow in direct-io subsystem
Date: Thu, 14 Oct 2010 14:20:23 -0400 [thread overview]
Message-ID: <x4962x41vrs.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <201010132245.57467.edward.shishkin@gmail.com> (Edward Shishkin's message of "Wed, 13 Oct 2010 22:45:57 +0200")
Edward Shishkin <edward.shishkin@gmail.com> writes:
> Fix up overflow (ssize_t->int) in the direct-io subsystem.
>
> Signed-off-by: Edward Shishkin <edward@redhat.com>
> ---
> fs/direct-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.36-rc7.orig/fs/direct-io.c
> +++ linux-2.6.36-rc7/fs/direct-io.c
> @@ -218,7 +218,7 @@ static struct page *dio_get_page(struct
> * filesystems can use it to hold additional state between get_block calls and
> * dio_complete.
> */
> -static int dio_complete(struct dio *dio, loff_t offset, int ret, bool is_async)
> +static ssize_t dio_complete(struct dio *dio, loff_t offset, ssize_t ret, bool is_async)
> {
> ssize_t transferred = 0;
Acked-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2010-10-14 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 20:45 [patch 1/2] vfs: fix overflow in direct-io subsystem Edward Shishkin
2010-10-14 11:17 ` Christoph Hellwig
2010-10-14 18:20 ` Jeff Moyer [this message]
2010-10-14 23:20 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x4962x41vrs.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=edward.shishkin@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lmcilroy@redhat.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).