From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [patch 1/2] vfs: fix overflow in direct-io subsystem
Date: Thu, 14 Oct 2010 14:20:23 -0400
Message-ID: <x4962x41vrs.fsf@segfault.boston.devel.redhat.com>
References: <201010132245.57467.edward.shishkin@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>,
	lmcilroy@redhat.com, LKML <linux-kernel@vger.kernel.org>
To: Edward Shishkin <edward.shishkin@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <201010132245.57467.edward.shishkin@gmail.com> (Edward Shishkin's
	message of "Wed, 13 Oct 2010 22:45:57 +0200")
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Edward Shishkin <edward.shishkin@gmail.com> writes:

> Fix up overflow (ssize_t->int) in the direct-io subsystem.
>
> Signed-off-by: Edward Shishkin <edward@redhat.com>
> ---
>  fs/direct-io.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.36-rc7.orig/fs/direct-io.c
> +++ linux-2.6.36-rc7/fs/direct-io.c
> @@ -218,7 +218,7 @@ static struct page *dio_get_page(struct 
>   * filesystems can use it to hold additional state between get_block calls and
>   * dio_complete.
>   */
> -static int dio_complete(struct dio *dio, loff_t offset, int ret, bool is_async)
> +static ssize_t dio_complete(struct dio *dio, loff_t offset, ssize_t ret, bool is_async)
>  {
>  	ssize_t transferred = 0;

Acked-by: Jeff Moyer <jmoyer@redhat.com>