From: Jeff Moyer <jmoyer@redhat.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Zach Brown <zab@zabbo.net>,
"Maxim V. Patlasov" <mpatlasov@parallels.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH V5 17/30] fs: use read_iter and write_iter rather than aio_read and aio_write
Date: Fri, 18 Jan 2013 16:26:20 -0500 [thread overview]
Message-ID: <x497gnai3nn.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1357761525-22718-18-git-send-email-dave.kleikamp@oracle.com> (Dave Kleikamp's message of "Wed, 9 Jan 2013 13:58:32 -0600")
Dave Kleikamp <dave.kleikamp@oracle.com> writes:
> @@ -1315,10 +1317,10 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
>
> if ((iocb->ki_opcode == IOCB_CMD_PREADV) ||
> (iocb->ki_opcode == IOCB_CMD_PREAD)) {
> - rw_op = file->f_op->aio_read;
> + rw_op = do_aio_read;
> opcode = IOCB_CMD_PREADV;
> } else {
> - rw_op = file->f_op->aio_write;
> + rw_op = do_aio_read;
> opcode = IOCB_CMD_PWRITEV;
> }
That wants to be rw_op = do_aio_write in the else clause. How did you
test this patch set?
Cheers,
Jeff
next prev parent reply other threads:[~2013-01-18 21:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 19:58 [PATCH V5 00/30] loop: Issue O_DIRECT aio using bio_vec Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 01/30] iov_iter: move into its own file Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 02/30] iov_iter: iov_iter_copy_from_user() should use non-atomic copy Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 03/30] iov_iter: add copy_to_user support Dave Kleikamp
[not found] ` <1357761525-22718-1-git-send-email-dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-01-09 19:58 ` [PATCH V5 04/30] fuse: convert fuse to use iov_iter_copy_[to|from]_user Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 22/30] nfs: simplify swap Dave Kleikamp
2013-01-09 20:01 ` Rik van Riel
2013-01-09 19:58 ` [PATCH V5 05/30] iov_iter: hide iovec details behind ops function pointers Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 06/30] iov_iter: add bvec support Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 07/30] iov_iter: add a shorten call Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 08/30] iov_iter: let callers extract iovecs and bio_vecs Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 09/30] dio: Convert direct_IO to use iov_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 10/30] dio: add bio_vec support to __blockdev_direct_IO() Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 11/30] fs: pull iov_iter use higher up the stack Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 12/30] aio: add aio_kernel_() interface Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 13/30] aio: add aio support for iov_iter arguments Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 14/30] bio: add bvec_length(), like iov_length() Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 15/30] loop: use aio to perform io on the underlying file Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 16/30] fs: create file_readable() and file_writable() functions Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 17/30] fs: use read_iter and write_iter rather than aio_read and aio_write Dave Kleikamp
2013-01-18 21:26 ` Jeff Moyer [this message]
2013-01-18 22:03 ` Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 18/30] fs: add read_iter and write_iter to several file systems Dave Kleikamp
2013-01-10 12:40 ` Boaz Harrosh
2013-01-09 19:58 ` [PATCH V5 19/30] ocfs2: add support for read_iter, write_iter, and direct_IO_bvec Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 20/30] ext4: add support for read_iter and write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 21/30] nfs: add support for read_iter, write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 23/30] btrfs: add support for read_iter and write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 24/30] block_dev: add support for read_iter, write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 25/30] xfs: add support for read_iter and write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 26/30] gfs2: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2013-01-10 10:10 ` Steven Whitehouse
2013-01-10 14:34 ` Dave Kleikamp
2013-01-11 16:24 ` Steven Whitehouse
2013-01-09 19:58 ` [PATCH V5 27/30] udf: convert file ops from aio_read/write " Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 28/30] afs: add support for read_iter and write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 29/30] ecrpytfs: Convert aio_read/write ops to read/write_iter Dave Kleikamp
2013-01-09 19:58 ` [PATCH V5 30/30] ubifs: convert file ops from aio_read/write " Dave Kleikamp
2013-01-10 15:46 ` [PATCH V5 00/30] loop: Issue O_DIRECT aio using bio_vec Sedat Dilek
2013-01-11 21:51 ` Dave Kleikamp
2013-01-12 10:52 ` Sedat Dilek
2013-01-12 12:54 ` Sedat Dilek
2013-01-16 16:32 ` James Bottomley
2013-01-16 18:25 ` Sedat Dilek
2013-01-17 23:49 ` James Bottomley
2013-01-18 17:16 ` Jeff Moyer
2013-01-18 17:56 ` Jeff Moyer
2013-01-18 17:58 ` Dave Kleikamp
2013-01-18 21:48 ` Jeff Moyer
2013-01-18 22:33 ` Dave Kleikamp
2013-01-22 16:14 ` Jeff Moyer
2013-01-20 22:26 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x497gnai3nn.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dave.kleikamp@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatlasov@parallels.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).