From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH V5 17/30] fs: use read_iter and write_iter rather than aio_read and aio_write
Date: Fri, 18 Jan 2013 16:26:20 -0500
Message-ID: <x497gnai3nn.fsf@segfault.boston.devel.redhat.com>
References: <1357761525-22718-1-git-send-email-dave.kleikamp@oracle.com>
	<1357761525-22718-18-git-send-email-dave.kleikamp@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zach Brown <zab@zabbo.net>,
	"Maxim V. Patlasov" <mpatlasov@parallels.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1357761525-22718-18-git-send-email-dave.kleikamp@oracle.com>
	(Dave Kleikamp's message of "Wed, 9 Jan 2013 13:58:32 -0600")
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Dave Kleikamp <dave.kleikamp@oracle.com> writes:

> @@ -1315,10 +1317,10 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
>  
>  	if ((iocb->ki_opcode == IOCB_CMD_PREADV) ||
>  		(iocb->ki_opcode == IOCB_CMD_PREAD)) {
> -		rw_op = file->f_op->aio_read;
> +		rw_op = do_aio_read;
>  		opcode = IOCB_CMD_PREADV;
>  	} else {
> -		rw_op = file->f_op->aio_write;
> +		rw_op = do_aio_read;
>  		opcode = IOCB_CMD_PWRITEV;
>  	}

That wants to be rw_op = do_aio_write in the else clause.  How did you
test this patch set?

Cheers,
Jeff