From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Toshi Kani <toshi.kani@hpe.com>,
akpm@linux-foundation.org, dan.j.williams@intel.com,
linux-nvdimm@ml01.01.org, david@fromorbit.com,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5] DAX: enable iostat for read/write
Date: Wed, 25 Jan 2017 10:15:50 -0500 [thread overview]
Message-ID: <x498tpznpax.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20170125111952.GA11978@infradead.org> (Christoph Hellwig's message of "Wed, 25 Jan 2017 03:19:52 -0800")
Christoph Hellwig <hch@infradead.org> writes:
> On Thu, Jan 12, 2017 at 11:38:48AM -0700, Toshi Kani wrote:
>> DAX IO path does not support iostat, but its metadata IO path does.
>> Therefore, iostat shows metadata IO statistics only, which has been
>> confusing to users.
>>
>> Add iostat support to the DAX read/write path.
>>
>> Note, iostat still does not support the DAX mmap path as it allows
>> user applications to access directly.
>
> NAK. DAX I/O should not be accounted for block device statistics.
Agreed, this is a layering violation.
Cheers,
Jeff
next prev parent reply other threads:[~2017-01-25 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 18:38 [PATCH v5] DAX: enable iostat for read/write Toshi Kani
2017-01-12 18:02 ` Joe Perches
2017-01-12 18:26 ` Kani, Toshimitsu
2017-01-25 11:19 ` Christoph Hellwig
2017-01-25 15:15 ` Jeff Moyer [this message]
2017-01-25 15:55 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x498tpznpax.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=toshi.kani@hpe.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).