Re: O_DIRECT on tmpfs (again)

[Jeff Moyer <jmoyer@redhat.com>]

Dave Kleikamp <dave.kleikamp@oracle.com> writes:

>> Whilst I agree with every contradictory word I said back then ;)
>> my current position is to wait to see what happens with Shaggy's "loop:
>> Issue O_DIRECT aio using bio_vec" https://lkml.org/lkml/2012/11/22/847
>
> As the patches exist today, the loop driver will only make the aio calls
> if the underlying file defines a direct_IO address op since
> generic_file_read/write_iter() will call a_ops->direct_IO() when
> O_DIRECT is set. For tmpfs or any other filesystem that doesn't support
> O_DIRECT, the loop driver will continue to call the read() or write()
> method.

Hi, Hugh and Shaggy,

Thanks for your replies--it looks like we're back to square one.  I
think it would be trivial to add O_DIRECT support to tmpfs, but I'm not
convinced it's necessary.  Should we wait until bug reports start to
come in?

Cheers,
Jeff

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>