* [PATCH] autofs4 - add missing kfree
@ 2008-06-20 7:09 Ian Kent
2008-06-20 13:02 ` Jeff Moyer
0 siblings, 1 reply; 2+ messages in thread
From: Ian Kent @ 2008-06-20 7:09 UTC (permalink / raw)
To: Andrew Morton; +Cc: Kernel Mailing List, autofs mailing list, linux-fsdevel
It see that the patch tittled "autofs4 - fix pending mount race" is
missing a change that I had recently made.
It's missing a kfree for the case mutex_lock_interruptible() fails
to aquire the wait queue mutex.
My appologies for this mistake.
Ian
Signed-off-by: Ian Kent <raven@themaw.net>
---
fs/autofs4/waitq.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index ae637d9..d291b07 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -328,8 +328,10 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry,
qstr.name = name;
qstr.hash = full_name_hash(name, qstr.len);
- if (mutex_lock_interruptible(&sbi->wq_mutex))
+ if (mutex_lock_interruptible(&sbi->wq_mutex)) {
+ kfree(qstr.name);
return -EINTR;
+ }
ret = validate_request(&wq, sbi, &qstr, dentry, notify);
if (ret <= 0) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] autofs4 - add missing kfree
2008-06-20 7:09 [PATCH] autofs4 - add missing kfree Ian Kent
@ 2008-06-20 13:02 ` Jeff Moyer
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Moyer @ 2008-06-20 13:02 UTC (permalink / raw)
To: Ian Kent
Cc: Andrew Morton, Kernel Mailing List, autofs mailing list,
linux-fsdevel
Ian Kent <raven@themaw.net> writes:
> It see that the patch tittled "autofs4 - fix pending mount race" is
> missing a change that I had recently made.
>
> It's missing a kfree for the case mutex_lock_interruptible() fails
> to aquire the wait queue mutex.
Yeah, missed that in the translation to the embedded qstr.
> Ian
>
> Signed-off-by: Ian Kent <raven@themaw.net>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-20 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-20 7:09 [PATCH] autofs4 - add missing kfree Ian Kent
2008-06-20 13:02 ` Jeff Moyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).