From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35092 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754530AbeEWQTD (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 23 May 2018 12:19:03 -0400
From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] 22.t: fix check for POLLIN
References: <20180523161407.30689-1-hch@lst.de>
        <20180523161407.30689-2-hch@lst.de>
Date: Wed, 23 May 2018 12:19:02 -0400
In-Reply-To: <20180523161407.30689-2-hch@lst.de> (Christoph Hellwig's message
        of "Wed, 23 May 2018 18:14:07 +0200")
Message-ID: <x49fu2iqr9l.fsf@segfault.boston.devel.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Christoph Hellwig <hch@lst.de> writes:

> Recent kernels seem to also set POLLRDNORM in addition to POLLIN,
> so check by masking instead of equality.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, Christoph, I'll pull this in.

-Jeff

> ---
>  harness/cases/22.t | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/harness/cases/22.t b/harness/cases/22.t
> index c7e7c0e..f376afc 100644
> --- a/harness/cases/22.t
> +++ b/harness/cases/22.t
> @@ -139,7 +139,7 @@ int test_main(void)
>  			printf("parent: io_pgetevents reports wrong fd\n");
>  			return 1;
>  		}
> -		if (ev.res != POLLIN) {
> +		if (!(ev.res & POLLIN)) {
>  			printf("parent: io_pgetevents did not report readable fd\n");
>  			return 1;
>  		}