[xfstests patch] 113: add testing for O_DIRECT + O_SYNC

[xfstests patch] 113: add testing for O_DIRECT + O_SYNC

[Jeff Moyer]

Hi,

This patch adds a couple more aio-stress runs to test 113.  The first
simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
2, which directs aio-stress to only perform the random write test.
These two tests helped identify several bugs in ext4.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

diff --git a/113 b/113
index 23676e0..b2ec510 100755
--- a/113
+++ b/113
@@ -100,4 +100,10 @@ _do_test 2 "-s 10m" $count $procs
 # as above, but now using direct IO
 _do_test 3 "-s 10m -O" $count $procs
 
+# dio with O_SYNC and unwritten extent conversion
+_do_test 4 "-s 10m -O -S" $count $procs
+
+# random dio writes with O_SYNC and unwritten extent conversion
+_do_test 5 "-s 10m -O -S -o 2" $count $procs
+
 exit
diff --git a/113.out b/113.out
index 1f3b866..aa856a6 100644
--- a/113.out
+++ b/113.out
@@ -12,3 +12,11 @@ aio-stress.2 : -t 20 -s 10m
 -----------------------------------------------
 aio-stress.3 : -t 20 -s 10m -O
 -----------------------------------------------
+
+-----------------------------------------------
+aio-stress.4 : -t 20 -s 10m -O -S
+-----------------------------------------------
+
+-----------------------------------------------
+aio-stress.5 : -t 20 -s 10m -O -S -o 2
+-----------------------------------------------

Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

[Eric Sandeen]

On 3/2/12 1:15 PM, Jeff Moyer wrote:
> Hi,
> 
> This patch adds a couple more aio-stress runs to test 113.  The first
> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.
> 
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

Looks fine, I'll check it into xfstests-dev, thanks!

-Eric

> 
> diff --git a/113 b/113
> index 23676e0..b2ec510 100755
> --- a/113
> +++ b/113
> @@ -100,4 +100,10 @@ _do_test 2 "-s 10m" $count $procs
>  # as above, but now using direct IO
>  _do_test 3 "-s 10m -O" $count $procs
>  
> +# dio with O_SYNC and unwritten extent conversion
> +_do_test 4 "-s 10m -O -S" $count $procs
> +
> +# random dio writes with O_SYNC and unwritten extent conversion
> +_do_test 5 "-s 10m -O -S -o 2" $count $procs
> +
>  exit
> diff --git a/113.out b/113.out
> index 1f3b866..aa856a6 100644
> --- a/113.out
> +++ b/113.out
> @@ -12,3 +12,11 @@ aio-stress.2 : -t 20 -s 10m
>  -----------------------------------------------
>  aio-stress.3 : -t 20 -s 10m -O
>  -----------------------------------------------
> +
> +-----------------------------------------------
> +aio-stress.4 : -t 20 -s 10m -O -S
> +-----------------------------------------------
> +
> +-----------------------------------------------
> +aio-stress.5 : -t 20 -s 10m -O -S -o 2
> +-----------------------------------------------
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

[Christoph Hellwig]

On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
> Hi,
> 
> This patch adds a couple more aio-stress runs to test 113.  The first
> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.

I'd rather make this a separate testcase, maybe moving the _do_test into
common code.

Rationale:  newly added tests shouldn't make old testcases fail, as that
would be rather confusing.

Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

[Eric Sandeen]

On 3/3/12 3:33 AM, Christoph Hellwig wrote:
> On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
>> Hi,
>>
>> This patch adds a couple more aio-stress runs to test 113.  The first
>> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
>> 2, which directs aio-stress to only perform the random write test.
>> These two tests helped identify several bugs in ext4.
> 
> I'd rather make this a separate testcase, maybe moving the _do_test into
> common code.
> 
> Rationale:  newly added tests shouldn't make old testcases fail, as that
> would be rather confusing.

Well, phooey, I committed it already.

I can do another patch to revert & add to a new test if you really want.

-Eric

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>