linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [patch,rfc] aio: allocate kiocbs in batches
Date: Thu, 08 Sep 2011 13:54:34 -0400	[thread overview]
Message-ID: <x49k49i7wdh.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20110901153503.47ac06fa.akpm@linux-foundation.org> (Andrew Morton's message of "Thu, 1 Sep 2011 15:35:03 -0700")

Andrew Morton <akpm@linux-foundation.org> writes:

> I do think the patch (and the surrounding code) can be improved in
> several ways.

Would you like a new patch that is a roll-up of the two you have in
your tree + any changes I'm making, or would you prefer a 3rd patch?

Btw, when changing 'called_fput' from an int to a bool, you forgot to
initialize it.  I'll fix it in the next round.

Cheers,
Jeff

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

      reply	other threads:[~2011-09-08 17:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 20:35 [patch,rfc] aio: allocate kiocbs in batches Jeff Moyer
2011-09-01  0:13 ` Andrew Morton
2011-09-01 13:56   ` Jeff Moyer
2011-09-01 22:35     ` Andrew Morton
2011-09-08 17:54       ` Jeff Moyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49k49i7wdh.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).