From: Jeff Moyer <jmoyer@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Lukas Czerner <lczerner@redhat.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2] fs: Fix page cache inconsistency when mixing buffered and AIO DIO
Date: Mon, 17 Jul 2017 15:52:24 -0400 [thread overview]
Message-ID: <x49lgnmj0xz.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20170717161705.GA22195@quack2.suse.cz> (Jan Kara's message of "Mon, 17 Jul 2017 18:17:05 +0200")
Jan Kara <jack@suse.cz> writes:
> On Mon 17-07-17 11:39:09, Jeff Moyer wrote:
>> Lukas Czerner <lczerner@redhat.com> writes:
>>
>> > About the error case, is it not possible that some data has already been
>> > writtent to the disk despite the error ?
>>
>> Yes, it's possible. However, that data is in an inconsistent state, so
>> it shouldn't be read, anyway.
>>
>> Now, in the non-async path, we do the invalidation unconditionally, so I
>> could go either way on this. I don't think it's going to matter for
>> performance or data integrity.
>
> Well, at least 'ret' would be negative in the error case so arguments
> passed to invalidate_inode_pages2_range() would be bogus if I'm reading the
> code right...
Ah, yes. Sorry, I was commenting on the more general point. You are
correct, in dio_complete, ret could be set to dio->page_errors or
dio->io_error. So yes, that needs to be checked.
-Jeff
next prev parent reply other threads:[~2017-07-17 19:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 15:17 [PATCH] fs: Fix page cache inconsistency when mixing buffered and AIO DIO Lukas Czerner
2017-07-14 10:41 ` kbuild test robot
2017-07-14 13:40 ` Lukas Czerner
2017-07-14 15:40 ` [PATCH v2] " Lukas Czerner
2017-07-17 15:12 ` Jan Kara
2017-07-17 15:28 ` Lukas Czerner
2017-07-17 15:39 ` Jeff Moyer
2017-07-17 16:17 ` Jan Kara
2017-07-17 19:52 ` Jeff Moyer [this message]
2017-07-18 7:39 ` Lukas Czerner
2017-07-18 9:06 ` Jan Kara
2017-07-18 9:32 ` Lukas Czerner
2017-07-18 12:19 ` [PATCH v3] " Lukas Czerner
2017-07-18 13:44 ` Christoph Hellwig
2017-07-18 14:17 ` Jan Kara
2017-07-19 8:42 ` Lukas Czerner
2017-07-19 8:48 ` [PATCH v4] " Lukas Czerner
2017-07-19 9:26 ` Jan Kara
2017-07-19 11:01 ` Lukas Czerner
2017-07-19 11:28 ` [PATCH v5] " Lukas Czerner
2017-07-19 11:37 ` Jan Kara
2017-07-19 12:17 ` Jeff Moyer
2017-08-03 18:10 ` Jeff Moyer
2017-08-04 10:09 ` Dave Chinner
2017-08-07 15:52 ` Jeff Moyer
2017-08-08 8:41 ` Lukas Czerner
2017-08-10 12:59 ` [PATCH v6] " Lukas Czerner
2017-08-10 13:56 ` Jan Kara
2017-08-10 14:22 ` Jeff Moyer
2017-08-11 9:03 ` Lukas Czerner
2017-08-14 9:43 ` Jan Kara
2017-08-15 12:47 ` Lukas Czerner
2017-08-15 13:28 ` [PATCH v7] " Lukas Czerner
2017-08-16 13:15 ` Jan Kara
2017-08-16 16:01 ` Darrick J. Wong
2017-09-21 13:44 ` Jeff Moyer
2017-09-21 13:44 ` Lukas Czerner
2017-09-21 14:14 ` Jens Axboe
2017-10-10 14:34 ` David Sterba
2017-10-11 9:21 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49lgnmj0xz.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).